Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-07-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/#review12855 --- Ship it! Ship It! - Matt Jordan On July 21, 2014, 5:19

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-07-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated July 24, 2014, 5:48 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-07-21 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated July 21, 2014, 5:19 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-07-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated July 9, 2014, 1:04 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-07-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated July 9, 2014, 2:05 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated June 30, 2014, 6:24 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-27 Thread rmudgett
On June 25, 2014, 6:16 p.m., Matt Jordan wrote: /branches/12/main/event.c, lines 146-167 https://reviewboard.asterisk.org/r/3601/diff/2/?file=60432#file60432line146 For the tweaks in this section that are unrelated to the accountcode changes, please commit them on a separate

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/#review12326 --- Well, this ended up being a lot more complex than we thought.

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-23 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated June 23, 2014, 3:56 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-10 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/#review12119 --- /branches/12/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-10 Thread rmudgett
On June 10, 2014, 5:13 p.m., Scott Griepentrog wrote: /branches/12/main/bridge_channel.c, lines 602-610 https://reviewboard.asterisk.org/r/3601/diff/1/?file=59438#file59438line602 I'm not understanding the need for this to be split out with separate join/leave handling. It seems

[asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- Review request for Asterisk Developers. Bugs: AFS-65 and ASTERISK-17954