Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-08-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12967 --- I think this should be taken to the asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12921 --- /branches/11/funcs/func_jitterbuffer.c

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/ --- (Updated July 30, 2014, 7:19 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12691 --- This review will probably need to account for this change in

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-19 Thread Joshua Colp
On June 10, 2014, 11:22 a.m., Joshua Colp wrote: /branches/11/main/channel.c, line 7113 https://reviewboard.asterisk.org/r/3603/diff/1/?file=59449#file59449line7113 This change is hazardous. It makes it so that some file descriptors on the original channel which were from the

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12107 --- /branches/11/main/channel.c

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-10 Thread Matt Jordan
On June 10, 2014, 6:22 a.m., Joshua Colp wrote: /branches/11/main/channel.c, line 7113 https://reviewboard.asterisk.org/r/3603/diff/1/?file=59449#file59449line7113 This change is hazardous. It makes it so that some file descriptors on the original channel which were from the past

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-10 Thread Corey Farrell
On June 10, 2014, 7:22 a.m., Joshua Colp wrote: /branches/11/main/channel.c, line 7113 https://reviewboard.asterisk.org/r/3603/diff/1/?file=59449#file59449line7113 This change is hazardous. It makes it so that some file descriptors on the original channel which were from the past

[asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22409

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12102 --- /branches/11/funcs/func_jitterbuffer.c