Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/#review12369 --- I'm not sure why this feature is necessary. Using pre-dial,

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread opticron
On June 27, 2014, 8 a.m., Matt Jordan wrote: I'm not sure why this feature is necessary. Using pre-dial, feature codes (via FEATUREMAP) can be set on either an inbound or an outbound channel prior to dialling. The fact that this channel data store is not always inherited means we

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/ --- (Updated June 27, 2014, 8:06 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-26 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-26 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/#review12355 --- Ship it! Ship It! - Jonathan Rose On June 26, 2014, 2:32

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/#review12368 --- trunk/tests/test_channel_feature_hooks.c