Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3716/#review12860 --- You are affecting the lifetime of the continer node object

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3716/#review12583 --- The ability to add an object to multiple weak reference

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-15 Thread George Joseph
On July 15, 2014, 2 p.m., Corey Farrell wrote: The ability to add an object to multiple weak reference containers is concerning to me. I think this adds unnecessary complexity/risk to astobj2. If you could tell me a use case where this amount of freedom is required I might be

[asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-07 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3716/ --- Review request for Asterisk Developers, Corey Farrell and rmudgett.