Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/ --- (Updated July 11, 2014, 2:27 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/#review12549 ---

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread Matt Jordan
On July 10, 2014, 3:15 p.m., rmudgett wrote: /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c, lines 19548-19551 https://reviewboard.asterisk.org/r/3740/diff/1/?file=62754#file62754line19548 I wonder why __unload_module() isn't called instead since we've

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread rmudgett
On July 10, 2014, 3:15 p.m., rmudgett wrote: /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c, lines 19548-19551 https://reviewboard.asterisk.org/r/3740/diff/1/?file=62754#file62754line19548 I wonder why __unload_module() isn't called instead since we've

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/ --- (Updated July 10, 2014, 3:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/#review12552 --- Ship it! I'm fine as far as chan_dahdi is concerned. -