---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 24, 2014, 12:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12806
---
Ship it!
Other than the two nitpicks below, this looks ready
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12807
---
/trunk/channels/chan_sip.c
On July 22, 2014, 11:24 a.m., rmudgett wrote:
/trunk/channels/chan_sip.c, lines 15568-15571
https://reviewboard.asterisk.org/r/3759/diff/4/?file=64989#file64989line15568
Something seems off here. The ao2_t_ref() calls return ints and are
parameters to AST_SCHED_REPLACE_UNREF().
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 22, 2014, 6:01 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12826
---
/trunk/channels/chan_sip.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 22, 2014, 8:27 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 22, 2014, 8:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 21, 2014, 4:54 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12772
---
/trunk/channels/chan_sip.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12784
---
/trunk/channels/chan_sip.c
On July 21, 2014, 1:14 p.m., Mark Michelson wrote:
/trunk/channels/chan_sip.c, lines 3522-3534
https://reviewboard.asterisk.org/r/3759/diff/3/?file=64859#file64859line3522
Heh, it's a bit late for this now, but it would have probably saved you
a bunch of searching and replacing
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12742
---
/trunk/channels/chan_sip.c
On July 18, 2014, 12:09 p.m., opticron wrote:
I'm going to run tests/channels/SIP then I'll update the diff.
On July 18, 2014, 12:09 p.m., opticron wrote:
/trunk/channels/chan_sip.c, lines 1190-1194
https://reviewboard.asterisk.org/r/3759/diff/2/?file=63077#file63077line1190
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 18, 2014, 7:39 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12595
---
This is working for me, although I can't qualify that it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 13, 2014, 12:48 a.m.)
Review request for Asterisk
18 matches
Mail list logo
