[asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12635 --- I've been working on a patch that makes very similar changes

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 9:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
On July 14, 2014, 9:37 p.m., rmudgett wrote: /team/group/media_formats-reviewed-trunk/main/translate.c, lines 335-339 https://reviewboard.asterisk.org/r/3783/diff/1/?file=63319#file63319line335 Is there a particular reason you are moving this code here? No reason, I was just moving

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12641 --- /team/group/media_formats-reviewed-trunk/main/translate.c

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 10:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12642 --- Ship it! Ship It! - rmudgett On July 14, 2014, 5:07 p.m.,

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 5:32 p.m.) Status -- This change has been