Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-07 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated Aug. 7, 2014, 4:25 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review13016 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread wdoekes
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3042 https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042 Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr ||

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread Alexander Traud
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3042 https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042 Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr ||

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread rmudgett
On Aug. 6, 2014, 1:58 a.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3042 https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042 Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr ||

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread ebroad
On Aug. 6, 2014, 2:58 a.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3042 https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042 Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr ||

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated Aug. 6, 2014, 2:04 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated Aug. 6, 2014, 2:03 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review13035 --- Ship it! Ship It! - Alexander Traud On Aug. 6, 2014, 6:04

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread Alexander Traud
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3042 https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042 Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr ||

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread Alexander Traud
On Aug. 6, 2014, 6:56 p.m., Alexander Traud wrote: Ship It! Not sure, if I am allowed to set that flag. Anyway, because I was invited, I think I have to. Everything fine from my side. (One part of the) community says thanks you for your contribution! - Alexander

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review13038 --- Ship it! Ship It! - rmudgett On Aug. 6, 2014, 1:04 p.m.,

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread rmudgett
On Aug. 6, 2014, 2:22 p.m., rmudgett wrote: Ship It! I'll commit this tomorrow if you don't have commit access. - rmudgett --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-06 Thread ebroad
On Aug. 6, 2014, 3:22 p.m., rmudgett wrote: Ship It! rmudgett wrote: I'll commit this tomorrow if you don't have commit access. Thanks! I don't have commit access. - ebroad --- This is an automatically generated e-mail. To

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-05 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated Aug. 5, 2014, 10:21 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-05 Thread ebroad
On Aug. 4, 2014, 1:17 p.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3041 https://reviewboard.asterisk.org/r/3882/diff/1/?file=65918#file65918line3041 Thank you for adding me to the list of reviewers. That way, I got E-mail notifications. No no-go from my

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-04 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review12970 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review12971 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-07-31 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated July 31, 2014, 2:14 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-07-31 Thread ebroad
On July 31, 2014, 2:11 p.m., rmudgett wrote: You need to add asterisk-dev to the Groups header for people to see the review. You need to use the full issue name ASTERISK-18345 in the Bugs header. Thanks! - ebroad --- This is an