Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-13 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/ --- (Updated Aug. 13, 2014, 10:21 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
On Aug. 8, 2014, 6:19 p.m., rmudgett wrote: /branches/12/apps/app_stack.c, lines 978-984 https://reviewboard.asterisk.org/r/3900/diff/1/?file=66461#file66461line978 Should just remove the UNBRIDGE references as this code is only for softhangup flags. On Aug. 8, 2014, 6:19

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
On Aug. 8, 2014, 6:19 p.m., rmudgett wrote: /branches/12/include/asterisk/channel.h, lines 1547-1554 https://reviewboard.asterisk.org/r/3900/diff/1/?file=66462#file66462line1547 This goes against the established defacto pattern. _locked vs _nolock It's slightly weird with the

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
On Aug. 8, 2014, 6:19 p.m., rmudgett wrote: /branches/12/main/channel.c, line 10182 https://reviewboard.asterisk.org/r/3900/diff/1/?file=66465#file66465line10182 This function may only care about ASYNCGOTO now. Unbridge may no longer have anything to do with this function.

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/ --- (Updated Aug. 11, 2014, 1:23 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/#review13076 --- /branches/12/apps/app_chanspy.c

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/#review13077 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
On Aug. 11, 2014, 2:05 p.m., rmudgett wrote: /branches/12/main/channel_internal_api.c, lines 1134-1145 https://reviewboard.asterisk.org/r/3900/diff/1-2/?file=66466#file66466line1134 Why were these changed? They were already using _nolock suffix. ast_channel_set_unbridged()

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
On Aug. 11, 2014, 2:05 p.m., rmudgett wrote: /branches/12/apps/app_stack.c, line 979 https://reviewboard.asterisk.org/r/3900/diff/1-2/?file=66461#file66461line979 Extra parens. This line may be short enought to not need line continuation. Still a bit longer than the other stuff

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/ --- (Updated Aug. 11, 2014, 4:15 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/#review13080 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/ --- (Updated Aug. 11, 2014, 5:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/#review13081 --- Ship it! Ship It! - rmudgett On Aug. 11, 2014, 5:06 p.m.,

[asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-08 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/ --- Review request for Asterisk Developers, Matt Jordan and rmudgett. Bugs:

Re: [asterisk-dev] [Code Review] 3900: Bridging: Fix an issue where bridge features can be interrupted by actions that set the UNBRIDGE soft hangup flag on a channel.

2014-08-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3900/#review13057 --- /branches/12/apps/app_stack.c