Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-20 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/ --- (Updated Aug. 20, 2014, 7:57 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
On Aug. 18, 2014, 2:47 p.m., rmudgett wrote: branches/12/main/stasis_bridges.c, line 627 https://reviewboard.asterisk.org/r/3921/diff/2/?file=66598#file66598line627 Please make this one declaration per line. json_transferer is leaked (new and pre-existing leak)

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
On Aug. 18, 2014, 2:47 p.m., rmudgett wrote: branches/12/main/stasis_bridges.c, line 627 https://reviewboard.asterisk.org/r/3921/diff/2/?file=66598#file66598line627 Please make this one declaration per line. json_transferer is leaked (new and pre-existing leak)

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/ --- (Updated Aug. 19, 2014, 7:29 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/#review13122 --- Ship it! Looks ok to me. - rmudgett On Aug. 19, 2014, 7:29

[asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/#review13108 --- branches/12/main/bridge.c