---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3982/
---
(Updated Sept. 16, 2014, 6:08 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3982/
---
(Updated Sept. 10, 2014, 11:24 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3982/#review13261
---
/branches/13/res/res_rtp_asterisk.c
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote:
/branches/13/res/res_rtp_asterisk.c, line 999
https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line999
Naming nitpick: thread is a bit too close to a keyword (it certainly
gets bolded in reviewboard). I'd rename
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote:
/branches/13/res/res_rtp_asterisk.c, lines 470-479
https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line470
This was clearly in this code prior to this patch, but it'd be nice if
component were typed to
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote:
/branches/13/res/res_rtp_asterisk.c, line 850
https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line850
Nitpick: no space between (int) and status.
rmudgett wrote:
I prefer
(int) status,
over
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3982/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23577 and