Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/ --- (Updated Sept. 16, 2014, 6:08 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/ --- (Updated Sept. 10, 2014, 11:24 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/#review13261 --- /branches/13/res/res_rtp_asterisk.c

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-08 Thread rmudgett
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote: /branches/13/res/res_rtp_asterisk.c, line 999 https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line999 Naming nitpick: thread is a bit too close to a keyword (it certainly gets bolded in reviewboard). I'd rename

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-08 Thread Matt Jordan
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote: /branches/13/res/res_rtp_asterisk.c, lines 470-479 https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line470 This was clearly in this code prior to this patch, but it'd be nice if component were typed to

Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-08 Thread rmudgett
On Sept. 8, 2014, 1:35 p.m., Matt Jordan wrote: /branches/13/res/res_rtp_asterisk.c, line 850 https://reviewboard.asterisk.org/r/3982/diff/1/?file=67291#file67291line850 Nitpick: no space between (int) and status. rmudgett wrote: I prefer (int) status, over

[asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23577 and