On April 10, 2015, 7:05 p.m., rmudgett wrote:
I'm posting my next diff here, then I will discard this review then post the
same change to gerrit. This way you can look at reviewboard to see the changes
between patches.
On April 10, 2015, 7:05 p.m., rmudgett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 12, 2015, 5:24 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 12, 2015, 5:29 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/#review15185
---
/trunk/main/astobj2.c
On April 10, 2015, 7:05 p.m., rmudgett wrote:
/trunk/main/astobj2.c, lines 492-494
https://reviewboard.asterisk.org/r/4108/diff/5-6/?file=71780#file71780line492
The comment doesn't make sense. How is destructor_fn supposed to
access values in the weak proxy? The real object is
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 3, 2015, 12:58 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/#review14995
---
This approach is much simpler and easier to understand than
On March 31, 2015, 5:52 p.m., rmudgett wrote:
/trunk/main/astobj2.c, line 798
https://reviewboard.asterisk.org/r/4108/diff/5/?file=71780#file71780line798
I think you need to have a weakproxy destructor callback that performs
a sanity check on the proxy object to ensure that it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated March 4, 2015, 4:43 p.m.)
Review request for Asterisk
On Dec. 9, 2014, 7:36 p.m., rmudgett wrote:
/trunk/main/astobj2.c, line 432
https://reviewboard.asterisk.org/r/4108/diff/3/?file=68553#file68553line432
Use of obj-priv_data.weakptr is not protected from other threads
creating a weak object from the object. This wouldn't be a
10 matches
Mail list logo
