Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 18, 2014, 9:25 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/#review13803 --- What you have found shows that the problem is in v12+ and not

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-18 Thread Corey Farrell
On Nov. 18, 2014, 1:19 p.m., rmudgett wrote: What you have found shows that the problem is in v12+ and not v1.8+ I had thought that the call to __ast_string_field_ptr_grow was a problem in 1.8/11 based on thinking that 'AST_STRING_FIELD_ALLOCATION(*ptr) += grow;' would modify the __p__,

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-17 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- (Updated Nov. 17, 2014, 10:48 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk