Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/ --- (Updated Dec. 8, 2014, 10:41 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24556

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/#review13891 --- Ship it! /branches/12/res/res_pjsip_session.c

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-04 Thread Mark Michelson
On Dec. 4, 2014, 9:45 p.m., Matt Jordan wrote: /branches/12/res/res_pjsip_session.c, line 497 https://reviewboard.asterisk.org/r/4233/diff/1/?file=69523#file69523line497 Completely ancillary to this... but I don't see where this gets used anywhere. :-) It's used by T.38 code. It

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-04 Thread Matt Jordan
On Dec. 4, 2014, 3:45 p.m., Matt Jordan wrote: /branches/12/res/res_pjsip_session.c, line 497 https://reviewboard.asterisk.org/r/4233/diff/1/?file=69523#file69523line497 Completely ancillary to this... but I don't see where this gets used anywhere. :-) Mark Michelson wrote: