Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/ --- (Updated Jan. 9, 2015, 3:58 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14131 --- Ship it! Since I only have a minor issue, I'll go ahead and

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Scott Griepentrog
On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote: Is this missing a sip.conf? It's using the bridge test case which is built on sip and includes it's own default sip.conf. Thus, I don't have to provide one in this test, and it would require changing the bridge test case, or at least

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14085 --- Ship it! I'll go ahead and ship it as this looks good to me,

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Kevin Harwell
On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote: Is this missing a sip.conf? Scott Griepentrog wrote: It's using the bridge test case which is built on sip and includes it's own default sip.conf. Thus, I don't have to provide one in this test, and it would require changing the

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14078 ---

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/ --- (Updated Dec. 31, 2014, 12:01 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-31 Thread Scott Griepentrog
On Dec. 23, 2014, 9:41 a.m., Matt Jordan wrote: /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml, line 35 https://reviewboard.asterisk.org/r/4256/diff/1/?file=69642#file69642line35 Minimum version should be the minimum expected Asterisk version that contains the

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14036 --- /asterisk/trunk/lib/python/asterisk/bridge_test_case.py

[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-12 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24513