Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-05 Thread Mark Michelson
On Dec. 30, 2014, 3:39 p.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/#review14080 --- Ship it! Ship It! - Mark Michelson On Dec. 30, 2014, 10:09

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Jan. 5, 2015, 4:43 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-02 Thread jbigelow
On Dec. 30, 2014, 9:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-02 Thread Kevin Harwell
On Dec. 30, 2014, 9:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2015-01-02 Thread George Joseph
On Dec. 30, 2014, 8:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/#review14053 --- branches/13/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Dec. 30, 2014, 3:03 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
On Dec. 30, 2014, 8:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Dec. 30, 2014, 3:09 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

2014-12-29 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- Review request for Asterisk Developers. Repository: Asterisk