Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/#review14089 --- Ship it! Ship It! - Matt Jordan On Jan. 6, 2015, 10:29

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- (Updated Jan. 6, 2015, 11:52 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- (Updated Jan. 6, 2015, 9:29 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread Mark Michelson
On Jan. 6, 2015, 12:11 a.m., Mark Michelson wrote: I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
On Jan. 5, 2015, 5:11 p.m., Mark Michelson wrote: I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/#review14081 --- I'm not sure I agree with this change. This can happen, like

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-05 Thread George Joseph
On Jan. 5, 2015, 5:11 p.m., Mark Michelson wrote: I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is

[asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-02 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- Review request for Asterisk Developers. Repository: Asterisk