Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/ --- (Updated Jan. 21, 2015, 7:34 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread rmudgett
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. Matt Jordan wrote: I'm not sure I understand your comment. cleanup_all_regs is being

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/#review14247 --- Ship it! Ship It! - Kevin Harwell On Jan. 19, 2015, 7:50

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/ --- (Updated Jan. 20, 2015, 10:13 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Matt Jordan
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. Matt Jordan wrote: I'm not sure I understand your comment. cleanup_all_regs is being

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/ --- (Updated Jan. 19, 2015, 7:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-19 Thread Matt Jordan
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. I'm not sure I understand your comment. cleanup_all_regs is being called by the ao2_callback,

[asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24640 and

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/#review14236 --- cleanup_all_regs() should just be the ao2_callback() line and