[asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:49 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

On Jan. 27, 2015, 3:57 p.m., rmudgett wrote: /branches/13/main/bridge_channel.c, lines 1998-2001 https://reviewboard.asterisk.org/r/4378/diff/1/?file=71097#file71097line1998 The reason a swap channel is pulled after the new channel is pushed is because pulling the last channel

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

On Jan. 27, 2015, 3:57 p.m., rmudgett wrote: /branches/13/main/bridge_channel.c, lines 1998-2001 https://reviewboard.asterisk.org/r/4378/diff/1/?file=71097#file71097line1998 The reason a swap channel is pulled after the new channel is pushed is because pulling the last channel

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14308 --- /branches/13/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14316 --- Ship it! I'm fine with the bridge core change. - rmudgett

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 11:32 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

On Jan. 27, 2015, 11:05 a.m., rmudgett wrote: I'm fine with the bridge core change. Quoting from my statements on IRC: (11:27:55 AM) mjordan: file: I'd say go ahead and ship in https://reviewboard.asterisk.org/r/4378/ (11:28:03 AM) mjordan: file: if we have some testsuite blow ups, I'd

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

On Jan. 27, 2015, 9:57 a.m., rmudgett wrote: /branches/13/main/bridge_channel.c, lines 1998-2001 https://reviewboard.asterisk.org/r/4378/diff/1/?file=71097#file71097line1998 The reason a swap channel is pulled after the new channel is pushed is because pulling the last channel

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14314 --- /branches/13/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

On Jan. 27, 2015, 9:57 a.m., rmudgett wrote: /branches/13/main/bridge_channel.c, lines 1998-2001 https://reviewboard.asterisk.org/r/4378/diff/1/?file=71097#file71097line1998 The reason a swap channel is pulled after the new channel is pushed is because pulling the last channel

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/ --- (Updated Jan. 27, 2015, 4:34 p.m.) Review request for Asterisk