Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/ --- (Updated Feb. 11, 2015, 11:28 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/#review14439 --- Ship it! Ship It! - Mark Michelson On Feb. 5, 2015, 9:58

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/ --- (Updated Feb. 5, 2015, 3:58 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-05 Thread rmudgett
On Feb. 4, 2015, 2:17 p.m., Mark Michelson wrote: While a shutdown request is pending it is desirable to continue to process ARI HTTP requests for current calls I'm curious what the justification behind this is. I would expect that for a now or graceful shutdown, you would want

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/#review14410 --- While a shutdown request is pending it is desirable to

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-03 Thread rmudgett
On Feb. 3, 2015, 1:43 p.m., Matt Jordan wrote: /branches/13/main/http.c, line 1877 https://reviewboard.asterisk.org/r/4399/diff/1/?file=71251#file71251line1877 I'd change this to a 503 Service Unavailable. If you hit this, the HTTP server is unavailable (but still running), and

[asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-02 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24752