---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/
---
(Updated Feb. 25, 2015, 3:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/#review14534
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 20, 2015, 2:41
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, line 290
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line290
Would
if (!strncmp(lifetime, 2^, 2))
accomplish the same thing here?
It should -
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, lines 306-311
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line306
Should the decimal lifetime reading also ensure that the value is not
greater than 2^48?
Matt
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, line 304
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line304
Since we're only concerned about an integer value here, would the
following work:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/
---
(Updated Feb. 19, 2015, 8:41 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/#review14486
---
/branches/11/channels/sip/sdp_crypto.c
On Feb. 18, 2015, 7:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, line 304
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line304
Since we're only concerned about an integer value here, would the
following work:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/#review14461
---
Thank you for doing this, Matt! This code has been heavily
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/
---
Review request for Asterisk Developers and Olle E Johansson.
Bugs:
10 matches
Mail list logo