Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-24 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/ --- (Updated Feb. 24, 2015, 12:23 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/#review14475 --- branches/11/bridges/bridge_softmix.c

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/#review14479 --- Ship it! Looks fine to me. Minor nit.

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread rmudgett
On Feb. 17, 2015, 9:19 a.m., Joshua Colp wrote: branches/11/bridges/bridge_softmix.c, line 317 https://reviewboard.asterisk.org/r/4429/diff/1/?file=71460#file71460line317 The setting of 0 here confuses me. If it's zero and on the next run some channels request it... won't that

[asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-16 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4429/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24797