Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14697 --- Ship it! I think this addresses the complexity that would be

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-16 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/ --- (Updated March 16, 2015, 5:40 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14599 --- I have made the following wiki changes based on feedback: *

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-05 Thread Mark Michelson
On March 2, 2015, 6:18 p.m., Matt Jordan wrote: Review of https://wiki.asterisk.org/wiki/display/AST/Notes+on+RTP+standards -- Section SRTP (RFC 3711) {quote} This document creates a new RTP profile, called RTP/SAVP. From section section 3: {quote} section repeated

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-05 Thread Mark Michelson
On March 2, 2015, 6:27 p.m., Matt Jordan wrote: Review: https://wiki.asterisk.org/wiki/display/AST/RTP+task+list I think it is worth putting somewhere on the task list the notion of testing RTP independent of a channel driver. That is, I'd like to be able to pass RTP packets into

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14566 --- Review of

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Olle E. Johansson
On 02 Mar 2015, at 16:54, Matt Jordan reviewbo...@asterisk.org wrote: {quote} Buffering/reordering RTP may be received in bursts, out of order, or in other less-than-ideal ways. Asterisk will implement reception buffers to place incoming RTP traffic into, potentially reordering packets

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements -session

2015-03-02 Thread Olle E. Johansson
Mark, One thing I think we have to look into is grouping of media sessions. You do not mention that, but you point to the bundle RFC. There are a few cases, like video conferences with left/right video and different options for audio - from high bandwidth to low bandwidth, lossy compression.

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Mark Michelson
On March 2, 2015, 3:54 p.m., Matt Jordan wrote: Review of https://wiki.asterisk.org/wiki/display/AST/RTP+engine+replacement -- Section: A glossary of terms {quote} * RTP stream: RTP instances created by Steel Zebra will be referred to as RTP streams. * RTP session: A

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Mark Michelson
On 03/02/2015 10:22 AM, Olle E. Johansson wrote: On 02 Mar 2015, at 16:54, Matt Jordan reviewbo...@asterisk.org mailto:reviewbo...@asterisk.org wrote: {quote} Buffering/reordering RTP may be received in bursts, out of order, or in other less-than-ideal ways. Asterisk will implement

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14568 --- Review of

Re: [asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-03-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/#review14569 --- Review:

[asterisk-dev] [Code Review] 4453: Asterisk 14: RTP improvements

2015-02-27 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4453/ --- Review request for Asterisk Developers. Description --- I've created