---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 18, 2015, 12:53 p.m.)
Status
--
This change has been
On March 16, 2015, 2:12 p.m., Matt Jordan wrote:
/trunk/main/dns_recurring.c, lines 89-91
https://reviewboard.asterisk.org/r/4474/diff/2/?file=72132#file72132line89
This could result in an explosion later if this is the last ref to hold
recurring.
This can't be the last ref, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14701
---
/trunk/include/asterisk/dns_core.h
On March 16, 2015, 9:12 a.m., Matt Jordan wrote:
/trunk/main/dns_recurring.c, lines 89-91
https://reviewboard.asterisk.org/r/4474/diff/2/?file=72132#file72132line89
This could result in an explosion later if this is the last ref to hold
recurring.
Joshua Colp wrote:
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 2:33 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14705
---
/trunk/include/asterisk/dns_core.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:26 p.m.)
Review request for Asterisk
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:24 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:22 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:56 p.m.)
Review request for Asterisk
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14709
---
Ship it!
Only problem is an easy memory leak to fix on
On March 11, 2015, 6:05 p.m., rmudgett wrote:
/trunk/include/asterisk/dns_recurring.h, line 48
https://reviewboard.asterisk.org/r/4474/diff/1/?file=71969#file71969line48
Since DNS resolution can take time, should the next refresh interval be
set in advance of the lowest returned
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14660
---
/trunk/main/dns_core.c
On March 12, 2015, 5:57 p.m., Mark Michelson wrote:
/trunk/main/dns_core.c, lines 285-290
https://reviewboard.asterisk.org/r/4474/diff/1/?file=71973#file71973line285
I was taking another look at this review and realized that there is
nothing here to ensure that we do not wait
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14641
---
/trunk/include/asterisk/dns_recurring.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24834
20 matches
Mail list logo
