Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/ --- (Updated March 27, 2015, 5:35 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-24 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/#review14823 --- /trunk/configs/basic-pbx/extensions.conf

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-24 Thread rnewton
On March 24, 2015, 10:39 p.m., rnewton wrote: /trunk/configs/basic-pbx/extensions.conf, lines 16-30 https://reviewboard.asterisk.org/r/4503/diff/1/?file=72533#file72533line16 These should move to the External-Features context and get their extensions changed to the full DID.

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-24 Thread rnewton
On March 24, 2015, 10:41 p.m., rnewton wrote: Tested with 4488, only a few modifications made. Emailed you a diff with the changes and external extensions. When testing this patch with 4488 I ran through the following tests: *patch1 - internal stuff* internal user to internal user

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-24 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/#review14825 --- Tested with 4488, only a few modifications made. Emailed you a

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-19 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/#review14752 --- As an update - when testing with my external connectivity

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-19 Thread rnewton
On March 17, 2015, 9:44 p.m., Mark Michelson wrote: Everything looks good here. Should this review stay open for the external extensions to be added, or will that be a separate review? Jonathan Rose wrote: I'll leave both reviews open for now. I'm finally testing with these with

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-17 Thread Jonathan Rose
On March 17, 2015, 4:44 p.m., Mark Michelson wrote: Everything looks good here. Should this review stay open for the external extensions to be added, or will that be a separate review? I'll leave both reviews open for now. - Jonathan

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-17 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/#review14730 --- Ship it! Everything looks good here. Should this review stay

[asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

2015-03-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4503/ --- Review request for Asterisk Developers. Repository: Asterisk