Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/#review14968 --- Ship it! ./branches/13/apps/app_stasis.c

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 31, 2015, 4:54 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 31, 2015, 5 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 9:54 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
On March 24, 2015, 1:15 p.m., rmudgett wrote: ./branches/13/apps/app_stasis.c, lines 77-79 https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line77 Using a parameter value before asserting that it is non-NULL is just wrong. That's just closing the

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 9:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 10:01 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 10:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 28, 2015, 12:38 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-25 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 25, 2015, 3:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread Joshua Colp
On March 23, 2015, 9:45 p.m., Matt Jordan wrote: ./branches/13/apps/app_stasis.c, lines 75-79 https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line75 You'll want to document this new channel variable in the XML documentation at the top of the file. Something

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/#review14792 --- ./branches/13/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/#review14803 --- ./branches/13/apps/app_stasis.c

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/#review14778 --- Make sure you document in the CHANGES file that app_stasis now

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-23 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/#review14780 --- ./branches/13/apps/app_stasis.c

[asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-22 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24802

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-22 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 22, 2015, 11:36 p.m.) Review request for Asterisk