---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 8, 2015, 1:15 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15089
---
Ship it!
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 6, 2015, 1:16 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15069
---
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15075
---
/certified/branches/13.1/res/res_pjsip_t38.c
On April 6, 2015, 4:16 p.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498
https://reviewboard.asterisk.org/r/4577/diff/3/?file=73632#file73632line493
How could this occur?
Jonathan Rose wrote:
As far as I know, it should never occur. I'm
On April 6, 2015, 8:59 a.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 514-524
https://reviewboard.asterisk.org/r/4577/diff/2/?file=73560#file73560line514
You aren't actually using the framehook id for anything. The sheer
presence of the datastore
On April 6, 2015, 11:16 a.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498
https://reviewboard.asterisk.org/r/4577/diff/3/?file=73632#file73632line493
How could this occur?
As far as I know, it should never occur. I'm probably being paranoid.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 6, 2015, 11:14 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15046
---
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 3, 2015, 12:03 p.m.)
Review request for Asterisk
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15036
---
/certified/branches/13.1/include/asterisk/res_pjsip_session.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15034
---
It is probably always the case that framehooks should not be
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15038
---
/certified/branches/13.1/include/asterisk/res_pjsip_session.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
Review request for Asterisk Developers and Joshua Colp.
Bugs:
19 matches
Mail list logo
