---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4080/#review13590
---
Ship it!
I tested all combinations of pass/fail and it works
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote:
/asterisk/trunk/runtests.py, line 75
https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75
This should include a + \n like line 59 does.
jbigelow wrote:
Line 59 adds a newline to visually separate the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4080/
---
(Updated Oct. 21, 2014, 9:57 a.m.)
Review request for Asterisk
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote:
/asterisk/trunk/runtests.py, line 75
https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75
This should include a + \n like line 59 does.
jbigelow wrote:
Line 59 adds a newline to visually separate the
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote:
/asterisk/trunk/runtests.py, line 75
https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75
This should include a + \n like line 59 does.
Line 59 adds a newline to visually separate the test that was run from
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote:
/asterisk/trunk/runtests.py, lines 82-83
https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82
While the extra parantheses are probably needed, generally, this
doesn't feel like the pythonic way to write this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4080/#review13558
---
Ship it!
Otherwise this works as advertised.
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote:
/asterisk/trunk/runtests.py, lines 82-83
https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82
While the extra parantheses are probably needed, generally, this
doesn't feel like the pythonic way to write this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4080/#review13533
---
/asterisk/trunk/runtests.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4080/
---
(Updated Oct. 15, 2014, 5:34 p.m.)
Review request for Asterisk
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote:
/asterisk/trunk/runtests.py, lines 82-83
https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82
While the extra parantheses are probably needed, generally, this
doesn't feel like the pythonic way to write this
11 matches
Mail list logo