---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 27, 2015, 2:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14881
---
Before committing I found a link error for utils/refcounter
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14835
---
Ship it!
Minor nit.
/branches/13/main/utils.c
On March 24, 2015, 5:08 p.m., rmudgett wrote:
/branches/13/main/logger.c, lines 1331-1332
https://reviewboard.asterisk.org/r/4502/diff/2/?file=72787#file72787line1331
I don't think this thread needs to be treated differently than any
other thread. The recursion check is thread
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 24, 2015, 6:05 p.m.)
Review request for Asterisk
On March 24, 2015, 1:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to know
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to
On March 24, 2015, 1:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to know
On March 24, 2015, 4:13 p.m., rmudgett wrote:
/branches/13/include/asterisk/utils.h, line 28
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72471#file72471line28
This can be removed as it was added for the backtrace
_ast_mem_backtrace_buffer[].
Ooops, it actually needs to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14808
---
/branches/13/include/asterisk/utils.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 24, 2015, 4:31 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14802
---
/branches/13/main/logger.c
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to
13 matches
Mail list logo
