---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
(Updated April 6, 2015, 12:06 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review15031
---
Ship it!
Ship It!
- Kevin Harwell
On April 1, 2015, 9:51
On March 31, 2015, 3:25 p.m., Matt Jordan wrote:
/team/group/dns/main/dns_naptr.c, lines 420-421
https://reviewboard.asterisk.org/r/4542/diff/2/?file=73012#file73012line420
The asserts here are appropriate.
However, if there is an error in the record, such that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
(Updated April 1, 2015, 2:51 p.m.)
Review request for Asterisk
On March 31, 2015, 10:25 a.m., Matt Jordan wrote:
/team/group/dns/main/dns_naptr.c, lines 447-449
https://reviewboard.asterisk.org/r/4542/diff/2/?file=73012#file73012line447
Suggestion: since this is repeated after each check, you may want to
macro-tize it:
#define
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review14984
---
/team/group/dns/include/asterisk/dns_internal.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review14972
---
/team/group/dns/include/asterisk/dns_internal.h
On March 31, 2015, 10:25 a.m., Matt Jordan wrote:
/team/group/dns/main/dns_naptr.c, lines 447-449
https://reviewboard.asterisk.org/r/4542/diff/2/?file=73012#file73012line447
Suggestion: since this is repeated after each check, you may want to
macro-tize it:
#define
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
(Updated March 27, 2015, 2:45 p.m.)
Review request for Asterisk
