[asterisk-dev] [Code Review] 3054: ARI: Add call forwarding events and automatically follow new channel

2013-12-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3054/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22719

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/#review10319 --- branches/12/res/res_pjsip/config_global.c

Re: [asterisk-dev] Presence State in Asterisk 11

2013-12-06 Thread Mark Michelson
Jason Parker Thursday, December 05, 2013 3:31 PM Presence State is a feature that was added in Asterisk 11, which allows for more information to be captured about the state of a user. There appears to have been a rather large oversight in the

Re: [asterisk-dev] [Code Review] 3045: app_page: Add predial handlers

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3045/#review10320 --- Ship it! /trunk/main/dial.c

[asterisk-dev] [Code Review] 3056: testsuite: stress test

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3056/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: AST-1179

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10321 --- On the one hand, using AppTest for this set of tests seems

[asterisk-dev] [Code Review] 3055: pbx.c: retain lock around ast_exten use to prevent memory corruption

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: AST-1179

Re: [asterisk-dev] [Code Review] 3056: testsuite: dialplan stress test to find memory allocation problems (valgrind)

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3056/ --- (Updated Dec. 6, 2013, 2:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
On Dec. 6, 2013, 8:45 p.m., Mark Michelson wrote: On the one hand, using AppTest for this set of tests seems like an overly-complicated approach to use, but on the other hand, it works, so it's fine by me. Only reason I'm not putting a Ship it! on this review is that I want to

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- (Updated Dec. 6, 2013, 9:01 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10323 --- Ok, this time it's just reviewboard being stupid. They are

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
On Dec. 6, 2013, 9:02 p.m., Jonathan Rose wrote: Ok, this time it's just reviewboard being stupid. They are showing up in the diff file. D configs D configs/ast1 D configs/ast1/extensions.conf D configs/ast1/amd.conf D configs/ast1/iax.conf A

[asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting. Basically, I'm thinking that while we should absolutely re-use the underlying plumbing ( we don't need 2 versions of ast_sip_for_each_contact, for

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 6, 2013, 3:41 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/#review10325 --- /branches/1.8/main/pbx.c

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10326 --- Ship it! Ship It! - Mark Michelson On Dec. 6, 2013, 9:01

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 6, 2013, 4:35 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 6, 2013, 4:44 p.m.) Review request for Asterisk Developers

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.8.0 Now Available

2013-12-06 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.8.0 DAHDI-Tools-v2.8.0 dahdi-linux-complete-2.8.0+2.8.0 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux http://downloads.asterisk.org/pub/telephony/dahdi-tools

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread Kevin Harwell
On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting. Basically, I'm thinking that while we should absolutely re-use the underlying plumbing

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting.

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread Kevin Harwell
On Fri, Dec 6, 2013 at 7:09 PM, George Joseph george.jos...@fairview5.comwrote: On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: snip Not suggesting separate lists for each object type. What I'm really

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, Dec 6, 2013 at 7:09 PM, George Joseph george.jos...@fairview5.com wrote: On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell kharw...@digium.comwrote: On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: snip

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread Kevin Harwell
On Fri, Dec 6, 2013 at 11:27 PM, George Joseph george.jos...@fairview5.comwrote: On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell kharw...@digium.comwrote: On Fri, Dec 6, 2013 at 7:09 PM, George Joseph george.jos...@fairview5.com wrote: On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell