Re: [asterisk-dev] [Code Review] 3173: chan_sip refactor - sip_route

2014-02-05 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3173/#review10758 --- Ship it! That addresses my concern sufficiently. Fire away.

[asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3183/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22537

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184/#review10759 --- This also needs a unit test to verify functionality and off

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
On Feb. 4, 2014, 4:53 p.m., Corey Farrell wrote: I like what you've done in general, I think the use of ao2 objects in timing implementations can be possibly stopped. Most (if not all) users of struct ast_timer are already protected by a lock or are owned exclusively by a single

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10761 --- Since this patch is optimazation-related, I have added some

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/ --- (Updated Feb. 5, 2014, 6:17 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10762 --- Ship it! Ship It! - Mark Michelson On Feb. 5, 2014, 6:17

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10763 --- Ship it! /trunk/include/asterisk/timing.h

Re: [asterisk-dev] [Code Review] 2990: Documentation: Clarify x Option In chan_spy

2014-02-05 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2990/#review10765 --- Ship it! Ship It! - rnewton On Nov. 2, 2013, 1:30 p.m.,

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-02-05 Thread rnewton
On Feb. 5, 2014, 7:37 p.m., rnewton wrote: Ship It! Tested command, output looks good and makes sense to me. - rnewton --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-02-05 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3136/#review10766 --- Ship it! Ship It! - rnewton On Feb. 3, 2014, 8:18 p.m.,

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184/ --- (Updated Feb. 5, 2014, 1:48 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- Review request for Asterisk Developers. Bugs: AST-1150

Re: [asterisk-dev] [Code Review] 3180: Documenation: Configuration section naming in pjsip.conf.sample needs a little clarification

2014-02-05 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3180/ --- (Updated Feb. 5, 2014, 9:10 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3186: AMI Security Events: document the events; add optional IEs to the events

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3186/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/#review10769 --- trunk/main/logger.c

[asterisk-dev] [Code Review] 3188: format_wav: enhancing log message Not a wav file to be clear on what is supported

2014-02-05 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3188/ --- Review request for Asterisk Developers. Summary (updated)

Re: [asterisk-dev] [Code Review] 3188: format_wav: enhancing log message Not a wav file to be clear on what is supported

2014-02-05 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3188/ --- (Updated Feb. 5, 2014, 10:14 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3188: format_wav: enhancing log message Not a wav file to be clear on what is supported

2014-02-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3188/#review10771 --- Ship it! Ship It! - Jonathan Rose On Feb. 5, 2014, 4:14

Re: [asterisk-dev] [Code Review] 3186: AMI Security Events: document the events; add optional IEs to the events

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3186/ --- (Updated Feb. 5, 2014, 4:51 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

2014-02-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3191/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23120

Re: [asterisk-dev] [Code Review] 3174: chan_iax2: Block unnecessary control frames to/from the wire.

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3174/#review10772 --- /branches/1.8/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3174: chan_iax2: Block unnecessary control frames to/from the wire.

2014-02-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3174/ --- (Updated Feb. 5, 2014, 6:13 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/#review10770 --- All of my comments have to do with implementation details as