[asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

2014-10-15 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

2014-10-15 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/#review13526 --- /asterisk/trunk/lib/python/asterisk/sippversion.py

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

2014-10-15 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/ --- (Updated Oct. 15, 2014, 11:53 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 4085: ExtensionStatus: Add additional documentation describing the ExtensionStatus event

2014-10-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4085/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

Re: [asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

2014-10-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/ --- (Updated Oct. 15, 2014, 2:05 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13527 --- You have red blobs on lines 164, 188, and 271.

Re: [asterisk-dev] [Code Review] 4074: AMI: Add missing VarSet events when a channel inherits variables.

2014-10-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4074/#review13528 --- Ship it! Ship It! - Mark Michelson On Oct. 13, 2014, 7:54

Re: [asterisk-dev] [Code Review] 4085: ExtensionStatus: Add additional documentation describing the ExtensionStatus event

2014-10-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4085/#review13529 --- /branches/13/main/manager.c

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13530 --- /branches/12/bridges/bridge_native_rtp.c

Re: [asterisk-dev] [Code Review] 3997: bridge_native_rtp: Fix odd audio issues when transitioning from native remote RTP bridge to softmix

2014-10-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3997/#review13531 --- Ship it! Otherwise g2g - Joshua Colp On Oct. 14, 2014,

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13532 --- /trunk/res/res_pjsip_keepalive.c

Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

2014-10-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13533 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

2014-10-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3948/#review13534 --- Ship it! Okay! In the interest of not letting what we are

Re: [asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

2014-10-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4062/#review13535 --- Ship it! This just sucks, but since the module loader can't

Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

2014-10-15 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 15, 2014, 5:34 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

2014-10-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4062/#review13536 --- Can you make the change in res_pjsip_phoneprov_provider while

Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration

2014-10-15 Thread jbigelow
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote: /asterisk/trunk/runtests.py, lines 82-83 https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82 While the extra parantheses are probably needed, generally, this doesn't feel like the pythonic way to write this