---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4576/#review15078
---
Nice job on the test! Just a few minor documentation findings.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 6, 2015, 1:16 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4592/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24835
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4540/
---
(Updated April 6, 2015, 12:52 p.m.)
Status
--
This change has been
Kevin Harwell has uploaded a new patch set (#3).
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
non_stasis_bridge_to_stasis_bridge: Update regex for ami events
Due to a bug in Asterisk, in
Ashley Sanders has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 3:
(4 comments)
I just found a few minor issues regarding docstrings, but
On April 6, 2015, 11:59 a.m., Matt Jordan wrote:
branches/11/main/ccss.c, lines 816-818
https://reviewboard.asterisk.org/r/4581/diff/2/?file=73569#file73569line816
Shouldn't this be:
if (sscanf(value, %30u, value_ast_uint) != 1) {
...
}
Yeah, this is
Ashley Sanders has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 2:
(4 comments)
A vast improvement over the previous approach. I think this version
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4581/
---
(Updated April 6, 2015, 1:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/
---
(Updated April 6, 2015, 2:23 p.m.)
Status
--
This change has been
Jonathan Rose has uploaded a new patch set (#4).
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Testsuite: New test for FAX via PJSIP T38 with authentication
Add a test for PJSIP t38 with
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Though I'm following ASTERISK-24863, I may have missed something: what
is this change replaced by?
Thanks,
- --
Jean-Denis Girard
SysNuxSystèmes Linux en Polynésie française
http://www.sysnux.pf/ Tél: +689 40.50.10.40
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24918
Ashley Sanders has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 4: Code-Review+1
Looks good.
--
To view, visit https://gerrit.asterisk.org/28
To
On Mon, Apr 6, 2015 at 3:56 PM, Jean-Denis Girard jd.gir...@sysnux.pf
wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Though I'm following ASTERISK-24863, I may have missed something: what
is this change replaced by?
Oops, I meant to update the ticket.
These are the 2 real
The Asterisk Development Team has announced the release of Asterisk 13.2.1.
This release is available for immediate download at
http://downloads.asterisk.org/pub/telephony/asterisk
The release of Asterisk 13.2.1 resolves an issue reported by the
community and would have not been possible without
The Asterisk Development Team has announced the release of Asterisk 13.3.1.
This release is available for immediate download at
http://downloads.asterisk.org/pub/telephony/asterisk
The release of Asterisk 13.3.1 resolves an issue reported by the
community and would have not been possible without
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/#review15081
---
/branches/13/apps/app_minivm.c
On April 7, 2015, 3:05 a.m., rmudgett wrote:
/branches/13/apps/app_minivm.c, line 1842
https://reviewboard.asterisk.org/r/4541/diff/3/?file=73407#file73407line1842
Missing the !
if (!ast_strlen_zero())
Thanks again for checking my stuff, and sorry for the mistakes.
-
Ashley Sanders has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/25
To unsubscribe,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4551/
---
(Updated April 6, 2015, 8:59 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4552/
---
(Updated April 6, 2015, 9:09 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4580/#review15082
---
So, maybe I'm doing this wrong, but...
1) Created
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4549/#review15065
---
Ship it!
Ship It!
- Joshua Colp
On April 6, 2015, 2:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4572/#review15070
---
Hey George - is this review useful anymore since you've got
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/#review15066
---
I think the t38_interpret_sdp function should be updated to
On April 6, 2015, 1:24 p.m., Joshua Colp wrote:
I think the t38_interpret_sdp function should be updated to only set the
far max datagram if not explicitly configured. Right now it will set it
again needlessly.
That is true if we can be sure that t38_initialize_session() has always
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15069
---
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/
---
(Updated April 6, 2015, 3:53 p.m.)
Review request for Asterisk
On April 6, 2015, 1:24 p.m., Joshua Colp wrote:
I think the t38_interpret_sdp function should be updated to only set the
far max datagram if not explicitly configured. Right now it will set it
again needlessly.
Juergen Spies wrote:
That is true if we can be sure that
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4572/
---
(Updated April 6, 2015, 8:46 a.m.)
Status
--
This change has been
On April 6, 2015, 7:52 a.m., Joshua Colp wrote:
Hey George - is this review useful anymore since you've got the two others?
Nope. Will discard.
- George
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15075
---
/certified/branches/13.1/res/res_pjsip_t38.c
On April 6, 2015, 4:16 p.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498
https://reviewboard.asterisk.org/r/4577/diff/3/?file=73632#file73632line493
How could this occur?
Jonathan Rose wrote:
As far as I know, it should never occur. I'm
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/#review15067
---
trunk/channels/chan_iax2.c
On April 6, 2015, 8:59 a.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 514-524
https://reviewboard.asterisk.org/r/4577/diff/2/?file=73560#file73560line514
You aren't actually using the framehook id for anything. The sheer
presence of the datastore
Matt Jordan has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 2:
(1 comment)
While my comment is piddly, I think a little bit more debug logging
On April 6, 2015, 11:16 a.m., Joshua Colp wrote:
/certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498
https://reviewboard.asterisk.org/r/4577/diff/3/?file=73632#file73632line493
How could this occur?
As far as I know, it should never occur. I'm probably being paranoid.
-
Matt Jordan has posted comments on this change.
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test The test will start two instances of Asterisk. The first will
originate a PJSIP call with authentication to the second using an extension
that will run sendFax.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 6, 2015, 11:14 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
(Updated April 6, 2015, 12:06 p.m.)
Status
--
This change has been
41 matches
Mail list logo
