Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Nir Simionovich
Ok, that helped - looks like I'm linking correctly now. Different question, I remember their used to be a "safe string copy" function that I'm supposed to use, instead of using strcpy. Mainly, I want to parse my configuration file correctly, but I can't find any specific methodology for doing

[asterisk-dev] Gerrit: Draft » Cherry-Pick » Publish = no check

2017-10-16 Thread Alexander Traud
Issue 1: When I 1) git review --draft ... on the command line of my computer, 2) cherry pick that change to other branches via the Web interface, and 3) publish those changes via the Web interface, I have to reply with "recheck" on the initial review, the one I submitted as draft via the command

Re: [asterisk-dev] Gerrit: Draft » Cherry-Pick » Publish = no check

2017-10-16 Thread Joshua Colp
On Mon, Oct 16, 2017, at 07:22 AM, Alexander Traud wrote: > Issue 1: > When I > 1) git review --draft ... on the command line of my computer, > 2) cherry pick that change to other branches via the Web interface, and > 3) publish those changes via the Web interface, > I have to reply with "recheck"

Re: [asterisk-dev] Gerrit: Draft » Cherry-Pick » Publish = no check

2017-10-16 Thread George Joseph
On Mon, Oct 16, 2017 at 4:35 AM, Joshua Colp wrote: > On Mon, Oct 16, 2017, at 07:22 AM, Alexander Traud wrote: > > Issue 1: > > When I > > 1) git review --draft ... on the command line of my computer, > > 2) cherry pick that change to other branches via the Web interface, and

Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Joshua Colp
On Mon, Oct 16, 2017, at 06:45 AM, Nir Simionovich wrote: > Ok, that helped - looks like I'm linking correctly now. > > Different question, I remember their used to be a "safe string copy" > function that I'm supposed to use, > instead of using strcpy. Mainly, I want to parse my configuration

Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Joshua Colp
On Mon, Oct 16, 2017, at 10:03 AM, Nir Simionovich wrote: > ok, managed to pass that hurdle - I'm basically using a fairly old piece > of > code to base my module on - namely, cdr_manager.c, > so the configuration parser in there is slightly different. > > Minor question, is there a "safe"

Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Nir Simionovich
ok, managed to pass that hurdle - I'm basically using a fairly old piece of code to base my module on - namely, cdr_manager.c, so the configuration parser in there is slightly different. Minor question, is there a "safe" asterisk method of doing a "sprintf"? On Mon, Oct 16, 2017 at 1:16 PM

Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Nir Simionovich
Hi All, So, my new cdr_beanstalkd module is available at team/nirs/beanstalkd-support . I'm not sure I've opened the review correctly, so would appreciate if someone can lend a hand on this one

Re: [asterisk-dev] chan_sip maintenance mode

2017-10-16 Thread Matt Fredrickson
On Wed, Oct 11, 2017 at 7:24 AM, Corey Farrell wrote: > I propose that we restrict the kind of bugs/patches that are accepted > against chan_sip to only major/critical bugs, regressions and security > fixes. This means rejecting all new features, improvements and most minor >

Re: [asterisk-dev] Adding a new module to Asterisk

2017-10-16 Thread Nir Simionovich
Thanks. The module is now finished - and also tested. I want to generate some tests and make sure it holds up, but in general - it's working as I expected it to work. On Mon, Oct 16, 2017 at 4:06 PM Joshua Colp wrote: > On Mon, Oct 16, 2017, at 10:03 AM, Nir Simionovich