[asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

2013-12-16 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3073/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22977

Re: [asterisk-dev] [Code Review] 3071: Testsuite: Check CEL Extra fields in an order-agnostic way

2013-12-16 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3071/ --- (Updated Dec. 16, 2013, 8:04 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/#review10419 --- Ship it! Ship It! - Matt Jordan On Dec. 11, 2013, 9:31

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Jonathan Rose
On Dec. 14, 2013, 1:39 p.m., Paul Belanger wrote: /branches/12/res/ari/ari_model_validators.h, lines 1066-1067 https://reviewboard.asterisk.org/r/3070/diff/3/?file=49603#file49603line1066 any change on dropping the bridge_ prefix. Seems redundant this is a bridge model.

[asterisk-dev] AppKonference 2.5

2013-12-16 Thread Paul Albrecht
Hi, I have released AppKonference 2.5 today. This release fixes a bug that can cause audio problems when conference frame caching is enabled. It also fixes the spy feature so that more than one spyer can spy on a channel at the same time. If more than one spyer is unmuted, their audio is

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Paul Belanger
On Dec. 14, 2013, 7:39 p.m., Paul Belanger wrote: /branches/12/rest-api/api-docs/bridges.json, lines 505-514 https://reviewboard.asterisk.org/r/3070/diff/3/?file=49607#file49607line505 Why are these required, but every place else appear to be optional? Jonathan Rose wrote:

Re: [asterisk-dev] [Code Review] 3068: ARI: provide a default format capability to channels that are created

2013-12-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3068/#review10422 --- Ship it! Ship It! - Joshua Colp On Dec. 12, 2013, 5:55

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

2013-12-16 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 16, 2013, 12:10 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Jonathan Rose
On Dec. 14, 2013, 1:39 p.m., Paul Belanger wrote: /branches/12/res/ari/ari_model_validators.h, lines 1066-1067 https://reviewboard.asterisk.org/r/3070/diff/3/?file=49603#file49603line1066 any change on dropping the bridge_ prefix. Seems redundant this is a bridge model.

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10423 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Jonathan Rose
On Dec. 13, 2013, 7:21 p.m., rmudgett wrote: /branches/12/res/res_stasis.c, line 607 https://reviewboard.asterisk.org/r/3070/diff/3/?file=49606#file49606line607 Stasis could give a name to the bridges it creates. This could aleviate some creation identification issues being

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/ --- (Updated Dec. 16, 2013, 2:47 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/#review10426 --- /branches/12/include/asterisk/bridge_internal.h

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/#review10427 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/ --- (Updated Dec. 16, 2013, 4:39 p.m.) Review request for Asterisk

[asterisk-dev] Asterisk 1.8.15-cert4, 1.8.24.1, 10.12.4, 10.12.4-digiumphones, 11.2-cert3, 11.6.1 Now Available (Security Release)

2013-12-16 Thread Asterisk Development Team
The Asterisk Development Team has announced security releases for Certified Asterisk 1.8.15, 11.2, and Asterisk 1.8, 10, and 11. The available security releases are released as versions 1.8.15-cert4, 11.2-cert3, 1.8.24.1, 10.12.4, 10.12.4-digiumphones, and 11.6.1. These releases are available for

[asterisk-dev] AST-2013-007: Asterisk Manager User Dialplan Permission Escalation

2013-12-16 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2013-007 ProductAsterisk SummaryAsterisk Manager User Dialplan Permission Escalation Nature of Advisory Permission Escalation

[asterisk-dev] AST-2013-006: Buffer Overflow when receiving odd length 16 bit SMS message

2013-12-16 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2013-006 ProductAsterisk SummaryBuffer Overflow when receiving odd length 16 bit SMS message

[asterisk-dev] Asterisk 1.8.25.0-rc2 Now Available

2013-12-16 Thread Asterisk Development Team
The Asterisk Development Team has announced the second release candidate of Asterisk 1.8.25.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 1.8.25.0-rc2 resolves several issues reported by the community

[asterisk-dev] Asterisk 11.7.0-rc2 Now Available

2013-12-16 Thread Asterisk Development Team
The Asterisk Development Team has announced the second release candidate of Asterisk 11.7.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.7.0-rc2 resolves several issues reported by the community and

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/#review10428 --- Ship it! /branches/12/main/bridge.c

[asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-16 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3074/ --- Review request for Asterisk Developers. Bugs: 20127

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3074/#review10429 --- Well, we can't just undo r354657, which is what this patch

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10430 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10431 --- My only other thought is that we really should limit this

Re: [asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3073/#review10432 --- I think the order is correct, based on the order of events