[asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/ --- Review request for Asterisk Developers. Bugs: ASTERISK-17179

[asterisk-dev] [Code Review] 3251: res_bucket_sounds: Add 'sounds' URI scheme implementation

2014-02-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3251/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3207: HEP: Add a Homer Encapsulation Protocol (HEP) v3 capture agent module and a packet logger for PJSIP

2014-02-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3207/#review10928 --- Ship it! Ship It! - Joshua Colp On Feb. 23, 2014, 5:48

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-02-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated Feb. 23, 2014, 5:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10929 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread wdoekes
On Feb. 23, 2014, 8:04 p.m., Corey Farrell wrote: /trunk/channels/sip/reqresp_parser.c, lines 103-118 https://reviewboard.asterisk.org/r/3250/diff/1/?file=54390#file54390line103 I feel this section should only apply when scheme is 'tel:'. I'm concerned with changes to how sip

[asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22537

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10931 --- /trunk/channels/sip/reqresp_parser.c

Re: [asterisk-dev] [Code Review] 3250: chan_sip: Add incoming tel: uri support (rfc3966)

2014-02-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3250/#review10932 --- I've gone ahead and rectified the access issue. If Geert would