[asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-02 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3282/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-02 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23276

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-02 Thread Moises Silva
On Feb. 27, 2014, 10:02 p.m., Matt Jordan wrote: /branches/11/res/res_http_websocket.c, lines 324-350 https://reviewboard.asterisk.org/r/3248/diff/1/?file=54350#file54350line324 So, I always get nervous every time I see a 'sanity' check polling loop :-) I know Thava

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-02 Thread Moises Silva
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3248/ --- (Updated March 3, 2014, 1:19 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

2014-03-02 Thread Moises Silva
On Feb. 27, 2014, 3:05 p.m., opticron wrote: /branches/11/res/res_http_websocket.c, line 318 https://reviewboard.asterisk.org/r/3248/diff/1/?file=54350#file54350line318 Turn this into a proper function that returns zero/non-zero for success/failure. That's fair, I got a little

[asterisk-dev] Changes to Review Board Access

2014-03-02 Thread Matthew Jordan
Hello everyone! For some time now, the Asterisk project has used Review Board [1] for performing code reviews on submitted patches. While having a patch be formally reviewed has never been a hard requirement for its inclusion, over time, the status quo in the project has evolved such that patches

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3282/#review11016 --- Ship it! Ship It! - Matt Jordan On March 2, 2014, 2:45

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3282/#review11017 --- /branches/11/res/res_musiconhold.c

Re: [asterisk-dev] [Code Review] 3269: chan_sip: fix deadlock of monlock between unload_module and do_monitor

2014-03-02 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3269/ --- (Updated March 2, 2014, 9:50 p.m.) Status -- This change has been