[asterisk-dev] Numbered placeholders in dialplan's SPRINTF function

2014-11-04 Thread Olivier
Hello, If I'm not mistaken, numbered placeholders are not supported by dialplan's SPRINTF function. Though this is strictly not blocking, having them would allow concise expressions such as: Dial(${SPRINTF(${PJSIPFORMAT},mytrunk,123456789)}) with : Set(PJSIPFORMAT=PJSIP/%2$s@%1$s)

Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-11-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2964/ --- (Updated Nov. 4, 2014, 6:03 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

2014-11-04 Thread Joshua Colp
On Oct. 29, 2014, 6:26 p.m., opticron wrote: /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/sipp/offer.xml, line 45 https://reviewboard.asterisk.org/r/4099/diff/2/?file=68484#file68484line45 The other three new tests should have this type of

Re: [asterisk-dev] [Code Review] 4099: Optimistic SRTP Tests.

2014-11-04 Thread opticron
On Oct. 29, 2014, 1:26 p.m., opticron wrote: /asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/sipp/offer.xml, line 45 https://reviewboard.asterisk.org/r/4099/diff/2/?file=68484#file68484line45 The other three new tests should have this type of

[asterisk-dev] [Code Review] 4147: config: BUG: Restore ability for non-templates to be used as base objects in config.

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4147/ --- Review request for Asterisk Developers and Scott Griepentrog. Bugs:

Re: [asterisk-dev] [Code Review] 4147: config: BUG: Restore ability for non-templates to be used as base objects in config.

2014-11-04 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4147/#review13667 --- Ship it! Ship It! - Scott Griepentrog On Nov. 4, 2014,

[asterisk-dev] [Code Review] 4148: res_pjsip_multihomed: Provide logging during startup for an indication of what is going on

2014-11-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4148/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24438

[asterisk-dev] Asterisk 14 - Remote URI Playback

2014-11-04 Thread Matthew Jordan
Hey everyone - One of the action items on the list from AstriDevCon was to flesh out some of the ARI feature proposals that had been made for Asterisk 13. I've just finished putting together a draft of the first one for Remote URI Playback. You can find the proposal page here:

Re: [asterisk-dev] Asterisk 14 - Remote URI Playback

2014-11-04 Thread BJ Weschke
Matt - This is a pretty neat idea, indeed, but I've got some questions/thoughts on implementation. :-) Apologies if all of this was already considered/accounted for already.. 1) Does the entire file need to be downloaded and in place on the HTTP Media Cache before you can call an

Re: [asterisk-dev] [Code Review] 4140: res_http_websockets: Module reference decrease below zero

2014-11-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4140/ --- (Updated Nov. 4, 2014, 1:30 p.m.) Status -- This change has been

Re: [asterisk-dev] Asterisk 14 - Remote URI Playback

2014-11-04 Thread Matthew Jordan
On Tue, Nov 4, 2014 at 12:57 PM, BJ Weschke bwesc...@btwtech.com wrote: Matt - This is a pretty neat idea, indeed, but I've got some questions/thoughts on implementation. :-) Apologies if all of this was already considered/accounted for already.. 1) Does the entire file need to be

Re: [asterisk-dev] [Code Review] 4147: config: BUG: Restore ability for non-templates to be used as base objects in config.

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4147/ --- (Updated Nov. 4, 2014, 2:47 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

2014-11-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4143/ --- (Updated Nov. 4, 2014, 2:57 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Nov. 4, 2014, 9:44 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-11-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13670 --- Ship it! Ship It! - opticron On Oct. 30, 2014, 7:02 p.m.,

Re: [asterisk-dev] [Code Review] 4148: res_pjsip_multihomed: Provide logging during startup for an indication of what is going on

2014-11-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4148/#review13672 --- Ship it! Ship It! - Mark Michelson On Nov. 4, 2014, 5:42

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/#review13673 --- Why the change to being a standalone script? I personally like

[asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

2014-11-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4149/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24492

Re: [asterisk-dev] [Code Review] 4146: res_pjsip: If an endpoint is associated with the dialog place it on the messag early

2014-11-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4146/#review13674 --- Ship it! Ship It! - Mark Michelson On Nov. 3, 2014, 5:55

Re: [asterisk-dev] [Code Review] 4145: testsuite: update pretty_print script for recent runtests.py changes.

2014-11-04 Thread George Joseph
On Nov. 4, 2014, 3:53 p.m., Mark Michelson wrote: Why the change to being a standalone script? I personally like the idea of it being a filter more. I changed it locally months back for 2 reasons... The first was that runtests wasn't pre-calculating and printing the total number of tests

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Nov. 4, 2014, 6:11 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4134: testsute: Add 'add-relative-to-search-path' handler to TestModuleLoader

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4134/ --- (Updated Nov. 4, 2014, 6:21 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4136: testsuite: Add escaped semicolons tests for UpdateConfig and dialplan save

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4136/ --- (Updated Nov. 5, 2014, 12:27 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4150: res_hep: fix major leak that occurs when config is missing or enabled=no

2014-11-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4150/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24491

Re: [asterisk-dev] [Code Review] 4150: res_hep: fix major leak that occurs when config is missing or enabled=no

2014-11-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4150/#review13677 --- Ship it! Ship It! - Joshua Colp On Nov. 5, 2014, 1:05

Re: [asterisk-dev] [Code Review] 4150: res_hep: fix major leak that occurs when config is missing or enabled=no

2014-11-04 Thread Matt Jordan
On Nov. 4, 2014, 7:07 p.m., Joshua Colp wrote: Ship It! Into 12 as well... thanks for the fix :-) - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4150/#review13677

Re: [asterisk-dev] Asterisk 14 - Remote URI Playback

2014-11-04 Thread BJ Weschke
On 11/4/14, 3:40 PM, Matthew Jordan wrote: On Tue, Nov 4, 2014 at 12:57 PM, BJ Weschke bwesc...@btwtech.com wrote: Matt - This is a pretty neat idea, indeed, but I've got some questions/thoughts on implementation. :-) Apologies if all of this was already considered/accounted for