On Nov. 13, 2014, 7:30 p.m., Mark Michelson wrote:
Looks good to me. The only suggestion I have is to modify the
tests/apps/confbridge/confbridge_marked_unmarked test in the testsuite to
expect the conf-hasleft sound to be played back in scenarios 2 and 3 to
the Normal-user channel.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4175/
---
(Updated Nov. 14, 2014, 8:22 a.m.)
Status
--
This change has been
On Nov. 5, 2014, 6:49 a.m., Joshua Colp wrote:
/tags/12.4.0/main/rtp_engine.c, lines 2012-2018
https://reviewboard.asterisk.org/r/4093/diff/1/?file=68394#file68394line2012
This is not compliant to the way L16 is supposed to be declared within
SDP. The payload name is supposed to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4174/
---
(Updated Nov. 14, 2014, 8:24 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4177/
---
(Updated Nov. 14, 2014, 8:54 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
(Updated Nov. 14, 2014, 9 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4167/#review13764
---
Make sure you update CHANGES with the new feature as well.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/
---
(Updated Nov. 14, 2014, 9:12 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4183/#review13766
---
branches/12/res/res_pjsip_phoneprov_provider.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4167/#review13767
---
This review has been shipped. I wrote the feature against
On Nov. 13, 2014, 11:07 p.m., Kevin Harwell wrote:
/asterisk/trunk/tests/bridge/atxfer_retries/configs/ast1/extensions.conf,
lines 18-40
https://reviewboard.asterisk.org/r/4168/diff/1/?file=68858#file68858line18
Are these extensions required by the test?
This is a template, so
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4168/
---
(Updated Nov. 14, 2014, 3:35 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4168/#review13768
---
The new diff is missing the test files.
- Kevin Harwell
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4139/
---
(Updated Nov. 14, 2014, 9:48 a.m.)
Status
--
This change has been
On Nov. 14, 2014, 8:12 a.m., Joshua Colp wrote:
branches/12/res/res_pjsip_phoneprov_provider.c, line 380
https://reviewboard.asterisk.org/r/4183/diff/1/?file=68985#file68985line380
Is this really needed? ast_sorcery_open calls __ast_sorcery_open with
the module name. This then
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4183/
---
(Updated Nov. 14, 2014, 8:56 a.m.)
Status
--
This change has been
On Nov. 13, 2014, 5:17 p.m., Kevin Harwell wrote:
/asterisk/trunk/lib/python/pcap_listener.py, lines 61-64
https://reviewboard.asterisk.org/r/4156/diff/1/?file=68770#file68770line61
Instead of checking for None here and then setting the value just set
these as the defaults on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4109/
---
(Updated Nov. 14, 2014, 11:42 a.m.)
Status
--
This change has been
On Nov. 13, 2014, 5:17 p.m., Kevin Harwell wrote:
/asterisk/trunk/lib/python/pcap_listener.py, lines 61-64
https://reviewboard.asterisk.org/r/4156/diff/1/?file=68770#file68770line61
Instead of checking for None here and then setting the value just set
these as the defaults on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4156/#review13773
---
Ship it!
Ship It!
- Kevin Harwell
On Nov. 6, 2014, 5:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4184/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24522
On Nov. 14, 2014, 9:30 a.m., Mark Michelson wrote:
This review has been shipped. I wrote the feature against trunk, but I'm
curious if 13's proposed policy would allow for such a change to be added
to it as well. Thoughts?
It would, and I think this should be fine for 13. It's a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4184/#review13779
---
Ship it!
This simple patch works fine for the one case since
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/#review13777
---
/branches/13/main/asterisk.c
On Nov. 14, 2014, 4:08 p.m., Corey Farrell wrote:
/branches/13/main/asterisk.c, line 3203
https://reviewboard.asterisk.org/r/4182/diff/2/?file=68987#file68987line3203
Does this actually initialize 256 bytes of '\0', or just initialize the
first byte?
Initializing a char array
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/
---
(Updated Nov. 14, 2014, 5:03 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4185/
---
Review request for Asterisk Developers, Joshua Colp and Mark Michelson.
27 matches
Mail list logo