Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/#review13911 --- branches/12/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4170: testsuite: Delete bridges on completion for a bunch of rest_api tests

2014-12-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4170/#review13913 --- Just wondering - where do we stand with this? Still

Re: [asterisk-dev] [Code Review] 4213: Stasis: Fix StasisStart and StasisEnd ordering and missing events

2014-12-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4213/#review13914 --- Ship it! Ship It! - Matt Jordan On Dec. 2, 2014, 1:34

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

2014-12-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/#review13915 --- Ship it! Ship It!

Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

2014-12-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/ --- (Updated Dec. 8, 2014, 3:38 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4213: Stasis: Fix StasisStart and StasisEnd ordering and missing events

2014-12-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4213/ --- (Updated Dec. 8, 2014, 9:41 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

2014-12-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4226/ --- (Updated Dec. 8, 2014, 9:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4231: New AMI/ARI events for connected line updates on a channel

2014-12-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4231/ --- (Updated Dec. 8, 2014, 9:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread George Joseph
On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: branches/12/res/res_pjsip_config_wizard.c, lines 261-283 https://reviewboard.asterisk.org/r/4190/diff/3/?file=69442#file69442line261 While forgiving this would yield an incomplete variable list, causing the resulting object to

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread Joshua Colp
On Dec. 8, 2014, 12:52 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_config_wizard.c, lines 261-283 https://reviewboard.asterisk.org/r/4190/diff/3/?file=69442#file69442line261 While forgiving this would yield an incomplete variable list, causing the resulting object to

Re: [asterisk-dev] [Code Review] 4233: res_pjsip_session: Fix crash that would occur when rescheduling a reinvite due to a 491 response.

2014-12-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4233/ --- (Updated Dec. 8, 2014, 10:41 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4234: Testsuite: Ensure that changes in /r/4233 result in Asterisk no longer crashing.

2014-12-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4234/ --- (Updated Dec. 8, 2014, 10:46 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread George Joseph
On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: branches/12/res/res_pjsip_config_wizard.c, lines 781-811 https://reviewboard.asterisk.org/r/4190/diff/3/?file=69442#file69442line781 This is a roundabout way to do this. Why not have an API function like

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify an originator when originating calls.

2014-12-08 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/#review13919 --- Ship it! Ship It! /branches/13/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4244: ari: Add originate with originator test.

2014-12-08 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/#review13920 --- Ship it! Ship It! - Scott Griepentrog On Dec. 5, 2014,

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread George Joseph
On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: branches/12/res/res_pjsip_config_wizard.c, line 746 https://reviewboard.asterisk.org/r/4190/diff/3/?file=69442#file69442line746 Is this is successful and last_config exists you may want to just remove the category from there if it

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-08 Thread George Joseph
On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: branches/12/res/res_pjsip_config_wizard.c, line 746 https://reviewboard.asterisk.org/r/4190/diff/3/?file=69442#file69442line746 Is this is successful and last_config exists you may want to just remove the category from there if it

[asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4246/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24342

Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

2014-12-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/#review13925 --- Ship it! Ship It! - opticron On Dec. 8, 2014, 9:38 a.m.,

Re: [asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4246/#review13924 --- branches/12/res/res_pjsip/pjsip_options.c

[asterisk-dev] Asterisk 11.15.0-rc1 Now Available

2014-12-08 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 11.15.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.15.0-rc1 resolves several issues reported by the community and

[asterisk-dev] Asterisk 12.8.0-rc1 Now Available

2014-12-08 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 12.8.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.8.0-rc1 resolves several issues reported by the community and

[asterisk-dev] Asterisk 13.1.0-rc1 Now Available

2014-12-08 Thread Asterisk Development Team
The Asterisk Development Team has announced the first release candidate of Asterisk 13.1.0. This release candidate is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 13.1.0-rc1 resolves several issues reported by the community and

Re: [asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-08 Thread opticron
On Dec. 8, 2014, 1:47 p.m., rmudgett wrote: branches/12/res/res_pjsip/pjsip_options.c, lines 416-421 https://reviewboard.asterisk.org/r/4246/diff/2/?file=69600#file69600line416 You need to check that the returned value is never zero. qualify_frequency could become zero if the

Re: [asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4246/#review13927 --- Ship it! branches/12/res/res_pjsip/pjsip_options.c

[asterisk-dev] Asterisk 12 - Security Fix Only Notice

2014-12-08 Thread Matthew Jordan
Hey everyone! This is a friendly reminder that Asterisk 12 will be entering security fix only mode soon. As a Standard release of Asterisk, Asterisk 12 received one year of maintenance fixes, and will receive one year of security fixes. Asterisk 12 was first released on 2013-12-20 - the one year

Re: [asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4246/#review13928 --- branches/12/CHANGES

[asterisk-dev] [Code Review] 4247: DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4247/ --- Review request for Asterisk Developers. Bugs: ASTERISK-19463 and

Re: [asterisk-dev] [Code Review] 4247: DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4247/ --- (Updated Dec. 8, 2014, 6:17 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4247: DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4247/#review13929 --- /branches/1.8/main/lock.c