Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

2014-12-09 Thread Matt Jordan
On Dec. 8, 2014, 9:19 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_publish.c, lines 1234-1248 https://reviewboard.asterisk.org/r/4178/diff/4/?file=69544#file69544line1234 I'd opt for verbose messages for these. And a reasonably high level for that. Probably Verbose

Re: [asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

2014-12-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4246/ --- (Updated Dec. 9, 2014, 7:59 a.m.) Status -- This change has been

[asterisk-dev] Planned maintenance for community services on Tuesday, 9th of December 2014

2014-12-09 Thread Digium's Asterisk Development Team
Tonight several community services will have intermittent availability due to maintenance. This maintenance will begin at approximately 9:00 PM CST[1] and should last no longer than three hours, ending around 12:00 AM CST. The affected services are: * JIRA issue tracker (issues.asterisk.org) *

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify an originator when originating calls.

2014-12-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243/ --- (Updated Dec. 9, 2014, 9:44 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4244: ari: Add originate with originator test.

2014-12-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/ --- (Updated Dec. 9, 2014, 9:47 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4247: DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-09 Thread rmudgett
On Dec. 8, 2014, 7:53 p.m., Matt Jordan wrote: /branches/1.8/main/lock.c, lines 135-141 https://reviewboard.asterisk.org/r/4247/diff/2/?file=69604#file69604line135 Given the code in __ast_rwlock_init, I'm not sure this code should still be commented out. Going _way_ back in time,

Re: [asterisk-dev] [Code Review] 4247: DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4247/ --- (Updated Dec. 9, 2014, 11:21 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4178: res_pjsip_outbound_publish: stack overflow when using non-default sorcery wizard

2014-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/ --- (Updated Dec. 9, 2014, 12:35 p.m.) Status -- This change has been

[asterisk-dev] Rules for binding with regards to RTP

2014-12-09 Thread Mark Michelson
During some testing being performed at Digium, a bit of unexpected behavior was discovered. While testing local RTP native bridging (also known as packet-to-packet or P2P bridging), RTP packets sent from Asterisk had an unexpected source IP address. In the configuration, Asterisk was bound to

Re: [asterisk-dev] Rules for binding with regards to RTP

2014-12-09 Thread Joshua Colp
Mark Michelson wrote: snip I propose the following algorithm as a fix for this issue: 1. If we are sending a media offer, and there is a configured media_address on the endpoint to which we are sending the offer, then bind the RTP stream to the media_address. This means that the rtp_ipv6

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-12-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4182/#review13932 --- Ship it! Ship It! - opticron On Nov. 14, 2014, 5:03 p.m.,

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

2014-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/ --- (Updated Dec. 9, 2014, 2:01 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4245: ARI/AMI: Include language in standard channel snapshot output

2014-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4245/ --- (Updated Dec. 9, 2014, 2:19 p.m.) Status -- This change has been

Re: [asterisk-dev] Rules for binding with regards to RTP

2014-12-09 Thread Mark Michelson
On 12/09/2014 01:42 PM, Joshua Colp wrote: Mark Michelson wrote: snip more snips So, yes. In an ICE scenario the code will provide candidates for all local addresses. If you are bound to only one then all the others will fail. This should be taken into account - but it ultimately

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-12-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4182/ --- (Updated Dec. 9, 2014, 2:46 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4232: Testsuite: Tests for AMI NewConnectedLine and ARI ChannelConnectedLine events

2014-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/ --- (Updated Dec. 9, 2014, 2:55 p.m.) Status -- This change has been

Re: [asterisk-dev] Rules for binding with regards to RTP

2014-12-09 Thread Joshua Colp
Mark Michelson wrote: On 12/09/2014 01:42 PM, Joshua Colp wrote: Mark Michelson wrote: snip more snips So, yes. In an ICE scenario the code will provide candidates for all local addresses. If you are bound to only one then all the others will fail. This should be taken into account - but it

Re: [asterisk-dev] [Code Review] 4108: Weak References

2014-12-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108/#review13933 --- Summary of this weak ref implementation: weak_proxy_obj - obj