Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

On Dec. 31, 2014, 3:46 p.m., Matt Jordan wrote: /branches/13/main/bridge_basic.c, lines 2398-2410 https://reviewboard.asterisk.org/r/4302/diff/1/?file=70051#file70051line2398 I'm not sure we should be clearing the reference here. Clearly, we need to clear the reference

Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4302/ --- (Updated Jan. 2, 2015, 10:46 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

On Dec. 30, 2014, 9:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

[asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24485

[asterisk-dev] [Code Review] 4313: func_config: Add ability to retrieve specific occurrence of a variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4313/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 4310: pjsip :Add tests for PJSIP_AOR and PJSIP_CONTACT dialplan functions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4310/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24341

[asterisk-dev] [Code Review] 4308: pjsip: Add PJSIP_AOR and PJSIP_CONTACT dialplan functions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4308/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24341

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

On Dec. 30, 2014, 9:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't

[asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4315/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24049

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/#review14070 --- Actually, response-client_state *should* be being unreffed

Re: [asterisk-dev] [Code Review] 4310: pjsip :Add tests for PJSIP_AOR and PJSIP_CONTACT dialplan functions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4310/#review14066 ---

Re: [asterisk-dev] [Code Review] 4283: Testsuite: Dual channel redirect tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4283/ --- (Updated Jan. 2, 2015, 2:11 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4308: pjsip: Add PJSIP_AOR and PJSIP_CONTACT dialplan functions

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4308/#review14065 --- Ship it! Ship It! - Kevin Harwell On Jan. 2, 2015, 12:05

Re: [asterisk-dev] [Code Review] 4305: pjsip cli: Fix sorting of contacts for 'pjsip list contacts'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4305/#review14067 --- Ship it! Ship It! - Kevin Harwell On Dec. 31, 2014, 5:18

[asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

On Dec. 30, 2014, 8:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't