Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Scott Griepentrog
On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote: Is this missing a sip.conf? It's using the bridge test case which is built on sip and includes it's own default sip.conf. Thus, I don't have to provide one in this test, and it would require changing the bridge test case, or at least

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14085 --- Ship it! I'll go ahead and ship it as this looks good to me,

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Kevin Harwell
On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote: Is this missing a sip.conf? Scott Griepentrog wrote: It's using the bridge test case which is built on sip and includes it's own default sip.conf. Thus, I don't have to provide one in this test, and it would require changing the

Re: [asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4296/#review14091 --- Ship it! Ship It! - Kevin Harwell On Jan. 6, 2015, 11:29

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14093 --- So, I applied the patch but am having trouble seeing what this

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
On Jan. 5, 2015, 4:47 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/include/res_pjsip_private.h, lines 123-141 https://reviewboard.asterisk.org/r/4311/diff/1/?file=70133#file70133line123 I unnastand the need for these functions, but I feel like they could be named more

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Mark Michelson
On Jan. 5, 2015, 10:47 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/include/res_pjsip_private.h, lines 123-141 https://reviewboard.asterisk.org/r/4311/diff/1/?file=70133#file70133line123 I unnastand the need for these functions, but I feel like they could be named more

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 6, 2015, 3:30 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

2015-01-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/#review14098 --- Ship it! Ship It! - Joshua Colp On Jan. 6, 2015, 10:21

[asterisk-dev] [Code Review] 4317: Testsuite: PJSIP remote attended transfer test

2015-01-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4317/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

2015-01-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/ --- (Updated Jan. 6, 2015, 10:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4285: Bug fixes for ARI Originate/Continue with label support (Continuation of /r/4101)

2015-01-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4285/ --- (Updated Jan. 6, 2015, 10:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
On Jan. 6, 2015, 2:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4315/#review14086 --- Since we are bumping the API should this be mentioned in the

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/#review14089 --- Ship it! Ship It! - Matt Jordan On Jan. 6, 2015, 10:29

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- (Updated Jan. 6, 2015, 11:52 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4314/ --- (Updated Jan. 6, 2015, 9:29 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread Mark Michelson
On Jan. 6, 2015, 12:11 a.m., Mark Michelson wrote: I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is

Re: [asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

2015-01-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4296/ --- (Updated Jan. 6, 2015, 5:29 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4305: pjsip cli: Fix sorting of contacts for 'pjsip list contacts'

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4305/ --- (Updated Jan. 6, 2015, 11:28 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4314: res_pjsip_mwi: Suppress another warning

2015-01-06 Thread George Joseph
On Jan. 5, 2015, 5:11 p.m., Mark Michelson wrote: I'm not sure I agree with this change. This can happen, like you said, due to MWI being indicated before an eventual registration. However, this can also happen due to a misconfiguration (either in Asterisk or the endpoint the MWI is