---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4349/
---
(Updated Jan. 20, 2015, 10:51 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4342/
---
(Updated Jan. 20, 2015, 10:46 a.m.)
Status
--
This change has been
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote:
cleanup_all_regs() should just be the ao2_callback() line and the original
guts should be put into a cleanup_registration() ao2_callback function.
Matt Jordan wrote:
I'm not sure I understand your comment. cleanup_all_regs is being
On Jan. 16, 2015, 10:59 a.m., Mark Michelson wrote:
branches/13/res/res_pjsip_pubsub.c, lines 3184-3187
https://reviewboard.asterisk.org/r/4347/diff/1/?file=70618#file70618line3184
This change seems incorrect. When we call pjsip_evsub_terminate(), the
PJ_TRUE parameter means we
On Jan. 19, 2015, 11:50 a.m., rmudgett wrote:
branches/13/res/parking/parking_applications.c, line 613
https://reviewboard.asterisk.org/r/4347/diff/1/?file=70612#file70612line613
Was there a problem with this already holding a retriever snapshot?
Otherwise this should just be an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4348/
---
(Updated Jan. 20, 2015, 12:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4362/
---
Review request for Asterisk Developers and Matt Jordan.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/
---
(Updated Jan. 20, 2015, 12:45 p.m.)
Review request for Asterisk
On Jan. 19, 2015, 4:24 p.m., Matt Jordan wrote:
/branches/13/main/bridge.c, line 1601
https://reviewboard.asterisk.org/r/4354/diff/1/?file=70760#file70760line1601
I don't think the join actually failed here. This should just get
called when bridge_channel_internal_join returns,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/
---
(Updated Jan. 20, 2015, 2:05 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/#review14243
---
branches/13/res/res_pjsip_pubsub.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4352/#review14248
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4355/#review14247
---
Ship it!
Ship It!
- Kevin Harwell
On Jan. 19, 2015, 7:50
On Jan. 20, 2015, 9:39 p.m., Mark Michelson wrote:
/branches/13/res/res_pjsip_multihomed.c, lines 149-150
https://reviewboard.asterisk.org/r/4316/diff/2/?file=70752#file70752line149
I think there are a couple of problems with this change:
1) You may be trying to access
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4316/#review14244
---
/branches/13/res/ari/resource_channels.c
On Jan. 20, 2015, 9:39 p.m., Mark Michelson wrote:
/branches/13/res/res_pjsip_multihomed.c, lines 149-150
https://reviewboard.asterisk.org/r/4316/diff/2/?file=70752#file70752line149
I think there are a couple of problems with this change:
1) You may be trying to access
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4341/
---
(Updated Jan. 20, 2015, 6:07 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/#review14249
---
Ship it!
Ship It!
- rmudgett
On Jan. 20, 2015, 2:37 p.m.,
Anybody tried asterisk connecting to Socket.io server as websocket client ?
I am not getting websocket established.
See below error, after successful 101 Switching Protocols
res_http_websocket.c:576 __ast_websocket_read: WebSocket unknown opcode 5
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4352/
---
(Updated Jan. 20, 2015, 10:06 p.m.)
Review request for Asterisk
On Jan. 20, 2015, 3:39 p.m., Mark Michelson wrote:
/branches/13/res/ari/resource_channels.c, lines 169-172
https://reviewboard.asterisk.org/r/4316/diff/2/?file=70750#file70750line169
Should this send an ARI response?
Nope! That's what I thought too. However, find_control, in its
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4355/
---
(Updated Jan. 20, 2015, 10:13 p.m.)
Review request for Asterisk
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote:
cleanup_all_regs() should just be the ao2_callback() line and the original
guts should be put into a cleanup_registration() ao2_callback function.
Matt Jordan wrote:
I'm not sure I understand your comment. cleanup_all_regs is being
On Jan. 20, 2015, 5:52 p.m., Mark Michelson wrote:
/asterisk/trunk/tests/rest_api/channels/redirect/nominal/run-test, lines
70-72
https://reviewboard.asterisk.org/r/4352/diff/1/?file=70737#file70737line70
Maybe this is just a philosophical thing, but why have this method? The
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4316/
---
(Updated Jan. 20, 2015, 9:39 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4347/
---
(Updated Jan. 20, 2015, 2:37 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4354/
---
(Updated Jan. 20, 2015, 1:06 p.m.)
Review request for Asterisk
27 matches
Mail list logo