Re: [asterisk-dev] [Code Review] 4349: Asterisk: Creating a named ARI bridge twice causes a crash

2015-01-20 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4349/ --- (Updated Jan. 20, 2015, 10:51 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4342: CHANNEL(peer), chan_iax2, res_fax, SNMP agent: Fix deadlock from reaching across a bridge.

2015-01-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4342/ --- (Updated Jan. 20, 2015, 10:46 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread rmudgett
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. Matt Jordan wrote: I'm not sure I understand your comment. cleanup_all_regs is being

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread Kevin Harwell
On Jan. 16, 2015, 10:59 a.m., Mark Michelson wrote: branches/13/res/res_pjsip_pubsub.c, lines 3184-3187 https://reviewboard.asterisk.org/r/4347/diff/1/?file=70618#file70618line3184 This change seems incorrect. When we call pjsip_evsub_terminate(), the PJ_TRUE parameter means we

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread Kevin Harwell
On Jan. 19, 2015, 11:50 a.m., rmudgett wrote: branches/13/res/parking/parking_applications.c, line 613 https://reviewboard.asterisk.org/r/4347/diff/1/?file=70612#file70612line613 Was there a problem with this already holding a retriever snapshot? Otherwise this should just be an

Re: [asterisk-dev] [Code Review] 4348: Testsuite: Creating a named ARI bridge twice causes a crash

2015-01-20 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4348/ --- (Updated Jan. 20, 2015, 12:47 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

2015-01-20 Thread Jeremiah Gowdy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4362/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/ --- (Updated Jan. 20, 2015, 12:45 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-20 Thread rmudgett
On Jan. 19, 2015, 4:24 p.m., Matt Jordan wrote: /branches/13/main/bridge.c, line 1601 https://reviewboard.asterisk.org/r/4354/diff/1/?file=70760#file70760line1601 I don't think the join actually failed here. This should just get called when bridge_channel_internal_join returns,

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/ --- (Updated Jan. 20, 2015, 2:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/#review14243 --- branches/13/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 4352: testsuite: Add tests for ARI redirect; PJSIP Transfer

2015-01-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4352/#review14248 ---

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/#review14247 --- Ship it! Ship It! - Kevin Harwell On Jan. 19, 2015, 7:50

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-20 Thread Mark Michelson
On Jan. 20, 2015, 9:39 p.m., Mark Michelson wrote: /branches/13/res/res_pjsip_multihomed.c, lines 149-150 https://reviewboard.asterisk.org/r/4316/diff/2/?file=70752#file70752line149 I think there are a couple of problems with this change: 1) You may be trying to access

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4316/#review14244 --- /branches/13/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-20 Thread Mark Michelson
On Jan. 20, 2015, 9:39 p.m., Mark Michelson wrote: /branches/13/res/res_pjsip_multihomed.c, lines 149-150 https://reviewboard.asterisk.org/r/4316/diff/2/?file=70752#file70752line149 I think there are a couple of problems with this change: 1) You may be trying to access

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-20 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4341/ --- (Updated Jan. 20, 2015, 6:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/#review14249 --- Ship it! Ship It! - rmudgett On Jan. 20, 2015, 2:37 p.m.,

[asterisk-dev] Asterisk with socket.io

2015-01-20 Thread Vipul Rastogi
Anybody tried asterisk connecting to Socket.io server as websocket client ? I am not getting websocket established. See below error, after successful 101 Switching Protocols res_http_websocket.c:576 __ast_websocket_read: WebSocket unknown opcode 5 --

Re: [asterisk-dev] [Code Review] 4352: testsuite: Add tests for ARI redirect; PJSIP Transfer

2015-01-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4352/ --- (Updated Jan. 20, 2015, 10:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-20 Thread Matt Jordan
On Jan. 20, 2015, 3:39 p.m., Mark Michelson wrote: /branches/13/res/ari/resource_channels.c, lines 169-172 https://reviewboard.asterisk.org/r/4316/diff/2/?file=70750#file70750line169 Should this send an ARI response? Nope! That's what I thought too. However, find_control, in its

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4355/ --- (Updated Jan. 20, 2015, 10:13 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread Matt Jordan
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. Matt Jordan wrote: I'm not sure I understand your comment. cleanup_all_regs is being

Re: [asterisk-dev] [Code Review] 4352: testsuite: Add tests for ARI redirect; PJSIP Transfer

2015-01-20 Thread Matt Jordan
On Jan. 20, 2015, 5:52 p.m., Mark Michelson wrote: /asterisk/trunk/tests/rest_api/channels/redirect/nominal/run-test, lines 70-72 https://reviewboard.asterisk.org/r/4352/diff/1/?file=70737#file70737line70 Maybe this is just a philosophical thing, but why have this method? The

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4316/ --- (Updated Jan. 20, 2015, 9:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/ --- (Updated Jan. 20, 2015, 2:37 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4354/ --- (Updated Jan. 20, 2015, 1:06 p.m.) Review request for Asterisk