---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4442/#review14522
---
I don't see the *_no_direction.xml files.
On Feb. 24, 2015, 2:29 a.m., wdoekes wrote:
./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_IP_media_restrict.xml,
line 213
https://reviewboard.asterisk.org/r/4442/diff/1/?file=71571#file71571line213
Heh, that was sloppy ;)
I blame whoever wrote this test initially.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14524
---
Ship it!
Ship It!
- Matt Jordan
On Feb. 24, 2015, 7:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14526
---
Ship it!
Ship It!
- Joshua Colp
On Feb. 24, 2015, 1:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4443/#review14527
---
/branches/13/main/dial.c
On Feb. 20, 2015, 2:37 p.m., Matt Jordan wrote:
/branches/13/configs/examples/awesome/extensions.conf, lines 29-31
https://reviewboard.asterisk.org/r/4379/diff/2/?file=71364#file71364line29
Is this comment correct still with this pattern match?
Nope. Fixed. I also adjusted the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
---
(Updated Feb. 24, 2015, 1:20 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4443/#review14528
---
Ship it!
Ship It!
- Joshua Colp
On Feb. 23, 2015, 11:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4442/
---
(Updated Feb. 24, 2015, 12:47 p.m.)
Review request for Asterisk
On Feb. 24, 2015, 2:29 a.m., wdoekes wrote:
I don't see the *_no_direction.xml files.
Sorry about that. The files are included in the update to this review. :)
- Ashley
---
This is an automatically generated e-mail. To reply, visit:
On Mon, Feb 23, 2015 at 2:07 PM, Olle E. Johansson o...@edvina.net wrote:
On 23 Feb 2015, at 20:10, Matthew Jordan mjor...@digium.com wrote:
On Mon, Feb 23, 2015 at 11:16 AM, James Cloos cl...@jhcloos.com wrote:
MJ == Matthew Jordan mjor...@digium.com writes:
MJ What I'm trying to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4441/#review14529
---
See coding guidelines:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4429/
---
(Updated Feb. 24, 2015, 12:23 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4442/#review14531
---
Ship it!
The only findings I have are very minor ones that
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4446/#review14543
---
No, this is not an appropriate place to ask questions. Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4431/#review14532
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 20, 2015, 3:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4418/#review14535
---
The 32-bit system overflow problem needs to be addressed on
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14539
---
First off, good page! It's pretty easy to follow the expected
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4447/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24751
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r//#review14533
---
Tested with a looped tdm board generating various DR patterns
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4434/
---
(Updated Feb. 24, 2015, 3:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/#review14534
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 20, 2015, 2:41
On Feb. 24, 2015, 4:29 p.m., Mark Michelson wrote:
The 32-bit system overflow problem needs to be addressed on this review.
I'll catch it when I do the merge over.
- Matt
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4446/
---
Review request for Asterisk Developers and Joshua Colp.
Summary (updated)
On Feb. 24, 2015, 5:35 p.m., Kevin Harwell wrote:
/branches/11/channels/chan_dahdi.c, lines 1965-1967
https://reviewboard.asterisk.org/r//diff/2/?file=71580#file71580line1965
Since you rearranged the 'ring - range' check should it be '' instead
of '='? Otherwise it is
25 matches
Mail list logo
