---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---
(Updated March 16, 2015, 7:37 p.m.)
Review request for Asterisk
On March 16, 2015, 6:47 p.m., rmudgett wrote:
/branches/13/channels/chan_sip.c, lines 1183-1184
https://reviewboard.asterisk.org/r/4189/diff/1/?file=72186#file72186line1183
Is there a reason why char *file cannot be const?
Looks like I copy/pasted the new parameters from
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4505/
---
(Updated March 17, 2015, 3:36 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4505/
---
(Updated March 17, 2015, 3:35 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4505/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24858
On March 13, 2015, 5:19 p.m., gareth wrote:
Ship It!
Well, if we're okay with the patch, then my initial comments still stand :-)
{quote}
1. For this to go into Asterisk 13, tests will need to be provided that cover
the new parameter. (Really, those tests should be written regardless)
2.
On March 16, 2015, 2:12 p.m., Matt Jordan wrote:
/trunk/main/dns_recurring.c, lines 89-91
https://reviewboard.asterisk.org/r/4474/diff/2/?file=72132#file72132line89
This could result in an explosion later if this is the last ref to hold
recurring.
This can't be the last ref, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/#review14698
---
/branches/13/configs/basic-pbx/extensions.conf
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4453/#review14697
---
Ship it!
I think this addresses the complexity that would be
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14701
---
/trunk/include/asterisk/dns_core.h
On March 16, 2015, 9:12 a.m., Matt Jordan wrote:
/trunk/main/dns_recurring.c, lines 89-91
https://reviewboard.asterisk.org/r/4474/diff/2/?file=72132#file72132line89
This could result in an explosion later if this is the last ref to hold
recurring.
Joshua Colp wrote:
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4491/#review14700
---
Ship it!
Ship It!
- Matt Jordan
On March 14, 2015, 6:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 2:33 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14705
---
/trunk/include/asterisk/dns_core.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:26 p.m.)
Review request for Asterisk
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4462/
---
(Updated March 16, 2015, 3:37 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4471/
---
(Updated March 16, 2015, 3:37 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:24 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:22 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 16, 2015, 3:56 p.m.)
Review request for Asterisk
On March 16, 2015, 2:55 p.m., Mark Michelson wrote:
/trunk/include/asterisk/dns_core.h, line 225
https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225
First off, apologies for bringing this up now rather than earlier, but
I did not think of this until over
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4453/
---
(Updated March 16, 2015, 5:40 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/#review14709
---
Ship it!
Only problem is an easy memory leak to fix on
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4504/
---
Review request for Asterisk Developers and rnewton.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4498/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24731
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---
(Updated March 16, 2015, 7:42 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14712
---
/branches/13/channels/chan_sip.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4499/#review14710
---
This change is full of red blobs (extra whitespace). In
Apologies for the messy merge of my branch. One learns all the time.
I tried merging the branch locally instead of using the pull request web
interface. One has to be careful with every commit - even to a local branch -
or just copy files between the branches and commit without a proper
32 matches
Mail list logo
