---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4499/
---
(Updated March 18, 2015, 9:01 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4474/
---
(Updated March 18, 2015, 12:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4512/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24836
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
(Updated March 18, 2015, 4:44 p.m.)
Review request for Asterisk
On March 16, 2015, 3:18 a.m., Matt Jordan wrote:
/trunk/res/res_timing_kqueue.c, lines 76-83
https://reviewboard.asterisk.org/r/4465/diff/2/?file=72098#file72098line76
For structure packing, you may want to declare this as:
struct kqueue_timer {
int handle;
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4477/#review14733
---
branches/11/apps/app_confbridge.c
On March 18, 2015, 12:39 p.m., rmudgett wrote:
branches/11/apps/app_confbridge.c, line 676
https://reviewboard.asterisk.org/r/4477/diff/2/?file=72633#file72633line676
Please get out of the habit of assigning in if tests:
digit = ast_stream_and_wait(...)
if (digit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4512/#review14737
---
I notice that there are red blobs in the unit tests I wrote.
On March 18, 2015, 11:02 p.m., Mark Michelson wrote:
I notice that there are red blobs in the unit tests I wrote. I'll get those
fixed up in the branch and post back here once I have that done.
I've committed the whitespace fixes.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4514/
---
Review request for Asterisk Developers and Joshua Colp.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4514/#review14738
---
Ship it!
Ship It!
- Joshua Colp
On March 18, 2015, 10:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/#review14735
---
A lot of the v11 patch findings apply to this review patch as
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4513/
---
Review request for Asterisk Developers.
Repository: Asterisk
13 matches
Mail list logo
