Re: [asterisk-dev] [Code Review] 3542: Documentation: Wiki page for Maintenance and Upgrades, including sub pages.

support life-cycle. - Scott Griepentrog On May 15, 2014, 4:13 p.m., rnewton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3542

Re: [asterisk-dev] [Code Review] 3542: Documentation: Wiki page for Maintenance and Upgrades, including sub pages.

, then later explain what they mean. It would be better to define the terms first, then use them. - Scott Griepentrog On May 15, 2014, 4:13 p.m., rnewton wrote: --- This is an automatically generated e-mail. To reply, visit: https

[asterisk-dev] [Code Review] 3539: pbx.c: segfault on recursive replace

/funcs/func_strings.c 413709 Diff: https://reviewboard.asterisk.org/r/3539/diff/ Testing --- Tested with example dialplan under valgrind to eliminate the reference to realloc'd string storage. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents

. - Scott --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3501/#review11815 --- On May 12, 2014, 3:43 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents

with r3496 valgrind support to insure no invalid references. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

--- On April 29, 2014, 11:15 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

--- On April 29, 2014, 11:15 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

/stasis.h 413115 /branches/12/apps/app_userevent.c 413115 Diff: https://reviewboard.asterisk.org/r/3494/diff/ Testing --- Tested with valgrind to insure no invalid references. Some leaks found which have been attributed to other code to be fixed separately. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

it not make more sense to generate custom user events from the events resource? Scott Griepentrog wrote: The idea is that a user event has to be signaled against/for an application, rather than a specific object, as there may be nothing more than the event name itself. It could

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

On May 6, 2014, 1:57 p.m., opticron wrote: /asterisk/trunk/tests/rest_api/channels/playback/tones/test-config.yaml, lines 39-43 https://reviewboard.asterisk.org/r/3428/diff/3/?file=58000#file58000line39 Are these channel state changes important to the test? There doesn't seem

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11809 --- On April 29, 2014, 11:15 a.m., Scott Griepentrog wrote

[asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

/asterisk/stasis_app.h 413115 /branches/12/apps/app_userevent.c 413115 Diff: https://reviewboard.asterisk.org/r/3494/diff/ Testing --- Tested with valgrind to insure no invalid references. Some leaks found which have been attributed to other code to be fixed separately. Thanks, Scott

[asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

/valgrind.supp PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3496/diff/ Testing --- Used to locate reference problems on Userevent issue, and incorporated several improvements over the prior attempt. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

issues affecting AMI/twisted operation have been seen and will be corrected. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents

--- Tests pass with userevent code. Also tested with r3496 valgrind support to insure no invalid references. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

On April 1, 2014, 5:10 p.m., Scott Griepentrog wrote: ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py, lines 328-329 https://reviewboard.asterisk.org/r/3313/diff/5/?file=56956#file56956line328 Be aware that the attempt to update the time on the file has a possibility

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

/pluggable_modules.py https://reviewboard.asterisk.org/r/3313/#comment21177 Minor nitpick: The log entry saying the file is moved will occur prior to this log entry saying the local file was created. Recommend moving this debug log entry to prior to move_file(). - Scott Griepentrog On April

Re: [asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

that you check the return value on the move and log any failures. - Scott Griepentrog On April 1, 2014, 2:57 p.m., Scott Emidy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

411312 /branches/1.8/main/http.c 411312 Diff: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

411312 /branches/1.8/main/manager.c 411312 /branches/1.8/main/http.c 411312 Diff: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

411242 Diff: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

/branches/12/main/manager.c 411242 /branches/12/main/http.c 411242 Diff: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

/branches/12/main/http.c 411242 Diff: https://reviewboard.asterisk.org/r/3402/diff/ Testing --- Tested on Ubuntu server 12.04 with Sam's json api test from issue. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3402/#review11401 --- On March 27, 2014, 1:52 p.m., Scott Griepentrog wrote

[asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

--- On March 26, 2014, 3:13 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3402

Re: [asterisk-dev] [Code Review] 3376: Crash in ast_format_cmp during non-clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3376/#review11373 --- Ship it! Ship It! - Scott Griepentrog On March 19, 2014

Re: [asterisk-dev] [Code Review] 3371: assigned-uniqueids: Misc cleanup and fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3371/#review11287 --- Ship it! Ship It! - Scott Griepentrog On March 18, 2014, 5

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11255 --- On March 14, 2014, 1:35 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

setting errno in the case that there is no content. Diffs (updated) - /branches/12/main/http.c 410554 Diff: https://reviewboard.asterisk.org/r/3360/diff/ Testing --- Passed my testing and also confirmed by Sam to fix the original failure he saw. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

failure he saw. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3356/#review11206 --- Ship it! Ship It! - Scott Griepentrog On March 14, 2014

Re: [asterisk-dev] [Code Review] 3316: CHANGES: update documentation for unique id changes

-23120 linkedid/uniqueid and ARI object id changes. Diffs - /branches/12/CHANGES 410156 Diff: https://reviewboard.asterisk.org/r/3316/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11181 --- On March 13, 2014, 12:37 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

first to avoid possible race condition, and also double check interfaces prior to all uses. Diffs - /branches/11/main/format.c 410525 Diff: https://reviewboard.asterisk.org/r/3209/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

double check interfaces prior to all uses. Diffs - /branches/11/main/format.c 410525 Diff: https://reviewboard.asterisk.org/r/3209/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation

[asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

/http.c 410554 Diff: https://reviewboard.asterisk.org/r/3360/diff/ Testing --- Passed my testing and also confirmed by Sam to fix the original failure he saw. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3356: Logic error in callerid checksum processing

On March 14, 2014, 1:18 p.m., rmudgett wrote: /branches/1.8/main/callerid.c, line 624 https://reviewboard.asterisk.org/r/3356/diff/1/?file=56016#file56016line624 I would be surprised if this worked for calls that the checksum was not zero. I think the expression

Re: [asterisk-dev] [Code Review] 3316: CHANGES: update documentation for unique id changes

. Diffs (updated) - /branches/12/CHANGES 410156 Diff: https://reviewboard.asterisk.org/r/3316/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

. Also ran some bridge tests to check for asserts. Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

://reviewboard.asterisk.org/r/3277/diff/ Testing --- All tests passed against r3191. Changing any specified id is detected by the test. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] [Code Review] 3316: CHANGES: update documentation for unique id changes

/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3242: starpy: add UniqueId parameter to ami.Originate()

--- Required for https://reviewboard.asterisk.org/r/3243/ File Attachments Update includes otherchannelid param https://reviewboard.asterisk.org/media/uploaded/files/2014/02/25/b803fe75-d355-4899-9396-66e774ed355c__starpy2.patch Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same (take 8)

/r/3193/diff/ Testing --- Ran command and checked output. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

--- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same (take 8)

/3193/diff/ Testing --- Ran command and checked output. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] PJSIP: allow/disallow or codecs?

] Scott Griepentrog Digium, Inc · Software Developer 445 Jan Davis Drive NW · Huntsville, AL 35806 · US direct/fax: +1 256 428 6239 · mobile: +1 317 507 4029 Check us out at: http://digium.com · http://asterisk.org -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

, visit: https://reviewboard.asterisk.org/r/3277/#review2 --- On March 4, 2014, 11:21 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] PJSIP: allow/disallow or codecs?

...@polybeacon.com wrote: On Thu, Mar 6, 2014 at 3:31 PM, George Joseph george.jos...@fairview5.com wrote: On Thu, Mar 6, 2014 at 1:22 PM, Scott Griepentrog sgriepent...@digium.com wrote: First, a smidgen of background: The two sorcery options for pjsip.conf allow and disallow both

Re: [asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

/lib/python/asterisk/ari.py 4735 Diff: https://reviewboard.asterisk.org/r/3277/diff/ Testing (updated) --- All tests passed against r3191. Changing any specified id is detected by the test. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

/test_config.py 4765 Diff: https://reviewboard.asterisk.org/r/3287/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

://reviewboard.asterisk.org/r/3287/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3242: starpy: add UniqueId parameter to ami.Originate()

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3242/#review11046 --- On Feb. 25, 2014, 3:42 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

--- On March 4, 2014, 2:43 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3191

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

ran some bridge tests to check for asserts. Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3258: testsuite: eliminate sipp zombie

) and added similar fix to Asterisk version test. Diffs - /asterisk/trunk/lib/python/asterisk/version.py 4735 /asterisk/trunk/lib/python/asterisk/sippversion.py 4735 Diff: https://reviewboard.asterisk.org/r/3258/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3132/diff/ Testing --- It correctly fails without the 3131 code implemented. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same (take 8)

/branches/12/include/asterisk/sorcery.h 409676 Diff: https://reviewboard.asterisk.org/r/3193/diff/ Testing --- Ran command and checked output. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

--- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

On March 4, 2014, 4:52 p.m., Matt Jordan wrote: So, we definitely need to get this in. Right now, however, I'm struggling with how we can test this. Ideally, we'd have some automated test in the Asterisk Test Suite, but besides getting a build agent with some special purpose

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

). - Scott --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3191/#review11052 --- On March 4, 2014, 5:54 p.m., Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

. Also ran some bridge tests to check for asserts. Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

hardware, I'm not sure how we're going to go about accomplishing that. Do you have any ideas? Scott Griepentrog wrote: Shouldn't it be possible to set up two transports as 127.0.0.1 and 127.0.0.2 and have sipp scenarios test each one? Joshua Colp wrote: As other tests have shown

Re: [asterisk-dev] [Code Review] 3278: ari: create bridges with specified unique id

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3278/#review11012 --- On Feb. 28, 2014, 11:39 a.m., Scott Griepentrog wrote

[asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

' in tests/rest_api/recording/basic/test-config.yaml, line 71, column 9 Diffs - /asterisk/trunk/lib/python/asterisk/test_config.py 4765 Diff: https://reviewboard.asterisk.org/r/3287/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phases 1-3: convert string uniqueid values to structure with time, add ami origination assignedid, add id's to ari objects

with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3278: ari: create bridges with specified unique id

409051 /branches/12/apps/app_bridgewait.c 409051 /branches/12/apps/app_agent_pool.c 409051 Diff: https://reviewboard.asterisk.org/r/3278/diff/ Testing --- Test https://reviewboard.asterisk.org/r/3277/ now includes a test for this feature, which passes. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: object uniqueid phases 1-3: ami/ari origination ami bridge, playback, and snoop

://reviewboard.asterisk.org/r/3191/diff/ Testing --- Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts. Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 3278: ari: create bridges with specified unique id

/app_agent_pool.c 409051 Diff: https://reviewboard.asterisk.org/r/3278/diff/ Testing --- Test https://reviewboard.asterisk.org/r/3277/ now includes a test for this feature, which passes. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

is detected by the test. Note: new bridge id test requires r3278. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

/3277/diff/ Testing --- Test passes against r3191. Changing any specified id is detected by the test. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same - OPTION 2

/asterisk/sorcery.h 407566 Diff: https://reviewboard.asterisk.org/r/3193/diff/ Testing --- Ran command and checked output. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3243: testsuite: manager Originate test for assigning UniqueId on channel creation

/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phases 12: convert string uniqueid values to structure with time, add ami origination assignedid

ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

/local/include/pj* to resolve conflicting structure). Diffs (updated) - /branches/12/channels/chan_pjsip.c 408931 Diff: https://reviewboard.asterisk.org/r/3267/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

/usr/local/include/pj* to resolve conflicting structure). Diffs - /branches/12/channels/chan_pjsip.c 408931 Diff: https://reviewboard.asterisk.org/r/3267/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3132/diff/ Testing --- It correctly fails without the 3131 code implemented. Thanks, Scott Griepentrog -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

/chan_pjsip.c 408931 Diff: https://reviewboard.asterisk.org/r/3267/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3242: starpy: add UniqueId parameter to ami.Originate()

/ Testing --- Required for https://reviewboard.asterisk.org/r/3243/ File Attachments (updated) Update includes otherchannelid param https://reviewboard.asterisk.org/media/uploaded/files/2014/02/25/b803fe75-d355-4899-9396-66e774ed355c__starpy2.patch Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phases 12: convert string uniqueid values to structure with time, add ami origination assignedid

://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3243: testsuite: manager Originate test for assigning UniqueId on channel creation

/originate/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/test_case.py 4722 Diff: https://reviewboard.asterisk.org/r/3243/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3258: testsuite: eliminate sipp zombie

://reviewboard.asterisk.org/r/3258/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3258: testsuite: eliminate sipp zombie

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3258/#review10934 --- On Feb. 24, 2014, 11:55 a.m., Scott Griepentrog wrote

[asterisk-dev] [Code Review] 3242: starpy: add UniqueId parameter to ami.Originate()

output of git diff https://reviewboard.asterisk.org/media/uploaded/files/2014/02/20/c8255dc9-d5fd-4591-9723-1c286e58e94e__starpy-uniqueid-originate.patch Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] [Code Review] 3243: testsuite: manager Originate test for assigning UniqueId on channel creation

/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phases 12: convert string uniqueid values to structure with time, add ami origination assignedid

. Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/ Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3213: ast_custom_escalating_function allocation leak

/1.8/main/pbx.c 407984 Diff: https://reviewboard.asterisk.org/r/3213/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

://reviewboard.asterisk.org/r/3191/#review10908 --- On Feb. 19, 2014, 3:38 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

/12/addons/chan_mobile.c 408019 Diff: https://reviewboard.asterisk.org/r/3191/diff/ Testing --- Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

/chan_ooh323.c 408019 /branches/12/addons/chan_mobile.c 408019 Diff: https://reviewboard.asterisk.org/r/3191/diff/ Testing --- Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

: https://reviewboard.asterisk.org/r/3191/diff/ Testing --- Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3182: testsuite: LinkedID Propagation test

(updated) --- This test is now running consistently without errors. It sill contains a warning on incorrect linkedid on CEL events which would have to be resolved in Asterisk. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3182: testsuite: LinkedID Propagation test

is now running consistently without errors. It sill contains a warning on incorrect linkedid on CEL events which would have to be resolved in Asterisk. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3182: testsuite: LinkedID Propagation test

is now running consistently without errors. It sill contains a warning on incorrect linkedid on CEL events which would have to be resolved in Asterisk. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3182: testsuite: LinkedID Propagation test

--- On Feb. 10, 2014, 2:37 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3182

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

/#review10811 --- On Feb. 13, 2014, 2:55 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3191

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

/chan_ooh323.c 408019 /branches/12/addons/chan_mobile.c 408019 Diff: https://reviewboard.asterisk.org/r/3191/diff/ Testing --- Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts. Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 3213: ast_custom_escalating_function allocation leak

--- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

<    1   2   3   4   >