change. Note the peeraccount value is meaningless
if the bridge does not contain two parties.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3813/#review12800
---
Ping for attention.
- rmudgett
On July 16, 2014, 4:37 p.m
On July 13, 2014, 4:22 p.m., rmudgett wrote:
ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is
not enabled.
We also seem to have two backtrace generation functions:
ao2_bt()
ast_log_bactrace()
Matt Jordan wrote:
We could consolidate these two
compiles.
- rmudgett
On July 18, 2014, 9:58 a.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3765
.
- rmudgett
On July 18, 2014, 11:30 a.m., Jacob Barber wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3829/
---
(Updated
On July 17, 2014, 4:38 p.m., rmudgett wrote:
/team/group/media_formats-reviewed-trunk/main/format_compatibility.c, line
176
https://reviewboard.asterisk.org/r/3822/diff/3/?file=64775#file64775line176
I'm not sure this should be moved from the core since the conversion
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3822/#review12753
---
Ship it!
Ship It!
- rmudgett
On July 17, 2014, 11:15 p.m
/#comment23071
This NOTICE is vague as to why it is declined. It looks more like a
resource allocation error rather than something the user possibly configured
wrong. How about:
Configured to decline creating Stasis message type %s\n
- rmudgett
On July 18, 2014, 9:54 a.m., opticron
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12763
---
Ship it!
Ship It!
- rmudgett
On July 16, 2014, 8:29 p.m
://reviewboard.asterisk.org/r/3728/#comment22999
Add fallthrough comment since there is no break.
- rmudgett
On July 10, 2014, 8:03 a.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
://reviewboard.asterisk.org/r/3729/#comment23000
command_queue is ref leaked.
- rmudgett
On July 10, 2014, 8:12 a.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3731/#review12715
---
team/rmudgett/stasis_linkedids/res/stasis/stasis_bridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3731/#review12716
---
team/rmudgett/stasis_linkedids/res/res_stasis.c
https
://reviewboard.asterisk.org/r/3721/#comment23010
A blank line should always separate variable declarations from code. It
makes them easier to spot.
- rmudgett
On July 15, 2014, 6:38 p.m., Jonathan Rose wrote:
---
This is an automatically generated
/features_config.c
https://reviewboard.asterisk.org/r/3809/#comment23013
This is the bug:
__features_config_alloc(0) should be features_config_alloc()
The globals config struct should always have those containers allocated.
- rmudgett
On July 16, 2014, 2:50 p.m., Scott Griepentrog
() and
ast_format_compatibility_codec2bitfield() are used by other modules than just
chan_iax2.
- rmudgett
On July 16, 2014, 9:46 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
/features_config.c
https://reviewboard.asterisk.org/r/3809/#comment23026
Same comment here.
- rmudgett
On July 17, 2014, 2:16 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviewboard.asterisk.org/r/3721/#comment23036
... result of a small ...
Extra space between the original
- rmudgett
On July 17, 2014, 3:10 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply
/media_formats-reviewed-trunk/main/format_compatibility.c
https://reviewboard.asterisk.org/r/3822/#comment23047
I'm not sure this should be moved from the core since the conversion the
other way is used by other modules.
- rmudgett
On July 17, 2014, 3:06 p.m., Corey Farrell wrote
---
Since I don't have a transcoder card I can only compile it.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
can only compile it.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
/codec_speex.c 418785
Diff: https://reviewboard.asterisk.org/r/3813/diff/
Testing
---
It compiles. I don't have anything that will consume/produce speex.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
anything default
compare function.
You are using the iterator in an unusual way here and other places.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12606
-trunk/main/format.c 418785
Diff: https://reviewboard.asterisk.org/r/3814/diff/
Testing
---
Made a warm fuzzy call with no problems.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api
the size of a pointer. I'm surprised this didn't crash from stack
corruption.
Look at using ast_str_substitute_variables() instead so you don't need to
create a worst case fixed sized buffer for any substituted variables.
- rmudgett
On July 16, 2014, 6:53 p.m., Michael Young wrote
had the joy of working with
the old object code.
- rmudgett
On July 16, 2014, 6:40 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3818
/3758/#comment22983
Excess indention.
/trunk/res/res_smdi.c
https://reviewboard.asterisk.org/r/3758/#comment22984
Yuck a shadowed variable.
- rmudgett
On July 16, 2014, 6:32 p.m., Corey Farrell wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3821/#review12706
---
Ship it!
I'm fine with it being in v12.
- rmudgett
On July
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3793/#review12656
---
Ship it!
Ship It!
- rmudgett
On July 15, 2014, 12:04 p.m
418653
/team/group/media_formats-reviewed-trunk/channels/chan_vpb.cc 418653
Diff: https://reviewboard.asterisk.org/r/3794/diff/
Testing
---
Now compiles
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http
. The users of the
array only pass a 0-31 index value not a (1 (0-31)) index value.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3787/#review12651
-reviewed-trunk/apps/app_jack.c 418654
Diff: https://reviewboard.asterisk.org/r/3787/diff/
Testing
---
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
compiles
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
/app_mixmonitor.c 418654
/team/group/media_formats-reviewed-trunk/apps/app_jack.c 418654
Diff: https://reviewboard.asterisk.org/r/3787/diff/
Testing
---
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3801/#review12671
---
Ship it!
Ship It!
- rmudgett
On July 15, 2014, 4:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3724/#review12680
---
Ship it!
Ship It!
- rmudgett
On July 15, 2014, 6:24 p.m
-reviewed-trunk/codecs/codec_dahdi.c 418753
Diff: https://reviewboard.asterisk.org/r/3803/diff/
Testing
---
Since I don't have a transcoder card I can only compile it.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
can only compile it.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
/media_formats-reviewed-trunk/main/translate.c 418567
/team/group/media_formats-reviewed-trunk/include/asterisk/translate.h 418567
Diff: https://reviewboard.asterisk.org/r/3775/diff/
Testing
---
Thanks,
rmudgett
://reviewboard.asterisk.org/r/3774/diff/
Testing
---
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
in v12.
* Use ao2_cleanup() on a global pointer in the __unload_module() routine for
safety.
Diffs
-
/team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c 418394
Diff: https://reviewboard.asterisk.org/r/3749/diff/
Testing
---
Thanks,
rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3745/#review12632
---
Ship it!
Ship It!
- rmudgett
On July 14, 2014, 11:48 a.m
://reviewboard.asterisk.org/r/3783/#comment22912
Move this line to before the t-newpvt() call. The destroy() unrefs the
module.
- rmudgett
On July 14, 2014, 2:04 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail
;
}
return pvt;
- rmudgett
On July 14, 2014, 4:57 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3783
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3783/#review12642
---
Ship it!
Ship It!
- rmudgett
On July 14, 2014, 5:07 p.m
/
Testing
---
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
On July 13, 2014, 4:22 p.m., rmudgett wrote:
ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is
not enabled.
We also seem to have two backtrace generation functions:
ao2_bt()
ast_log_bactrace()
Matt Jordan wrote:
We could consolidate these two
ao2_container_alloc_list() instead of expressing it as a degenerate
hash container.
/trunk/res/res_smdi.c
https://reviewboard.asterisk.org/r/3758/#comment22898
Use ao2_container_alloc_list() instead of expressing it as a degenerate
hash container.
- rmudgett
On July 12, 2014, 6:38 p.m
(original) for
call pickup.
SIP/100 (codec list: gsm, alaw) and was using alaw
After the pickup masquerade it would be using gsm.
- rmudgett
On July 11, 2014, 9:53 p.m., Matt Jordan wrote:
---
This is an automatically
/media_formats-reviewed-trunk/main/translate.c 418567
/team/group/media_formats-reviewed-trunk/include/asterisk/logger.h 418567
Diff: https://reviewboard.asterisk.org/r/3774/diff/
Testing
---
Thanks,
rmudgett
wants the number of current references and not to change it.
- rmudgett
On July 12, 2014, 1:13 a.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3756
://reviewboard.asterisk.org/r/3745/#comment22848
Since passing an empty argument is valid the function shouldn't return -1
but set the buffer to an empty string and return 0.
The same for the decode.
- rmudgett
On July 11, 2014, 11:09 a.m., Jonathan Rose wrote
-weasels
from an ISDN phone.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
-reviewed-trunk/channels/chan_dahdi.c 418394
Diff: https://reviewboard.asterisk.org/r/3749/diff/
Testing
---
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
On July 11, 2014, 5:22 p.m., Corey Farrell wrote:
Ship It!
Should be just committed to trunk and let automerge take care of the
media_formats merge.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
: https://reviewboard.asterisk.org/r/3748/diff/
Testing
---
The ref leak no longer happens when I call into dialplan to playback tt-weasels
from an ISDN phone.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3755/#review12584
---
Ship it!
Ship It!
- rmudgett
On July 11, 2014, 11:36 p.m
/chan_dahdi.c
https://reviewboard.asterisk.org/r/3740/#comment22837
I wonder why __unload_module() isn't called instead since we've allocated a
bunch of other stuff.
- rmudgett
On July 10, 2014, 2:41 p.m., Matt Jordan wrote
On July 10, 2014, 3:15 p.m., rmudgett wrote:
/team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c, lines
19548-19551
https://reviewboard.asterisk.org/r/3740/diff/1/?file=62754#file62754line19548
I wonder why __unload_module() isn't called instead since we've
.
- rmudgett
On July 10, 2014, 3:33 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3740/
---
(Updated July 10
? Seems potentially too small.
Is there precedent for accountcode to be this small?
- rmudgett
On July 7, 2014, 9:30 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
with
accountcode with more to come.
- rmudgett
On July 7, 2014, 9:32 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3725
manipulation because there aren't enough events to indicate
when the account codes change. Note the peeraccount value is meaningless
if the bridge does not contain two parties.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
is used after
free.
- rmudgett
On July 7, 2014, 5:21 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3721
to the channel.
- rmudgett
On July 8, 2014, 8:07 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3728/
---
(Updated
the name iter instead of the single char name i.
- rmudgett
On July 8, 2014, 8:24 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729
-config.yaml
https://reviewboard.asterisk.org/r/3732/#comment22808
Should have a chan_pjsip dependency in the list.
- rmudgett
On July 8, 2014, 9:06 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3731/#review12532
---
team/rmudgett/stasis_linkedids/res/res_stasis.c
https
the linkedids are propagated like the basic bridge sub-class.
Accountcodes will be propagated too when peeraccount support is truly
implemented on trunk.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http
,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
that the connection closed as requested when completed.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
that become nothing when TEST_FRAMEWORK is not
enabled.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3699/#review12478
know what issue
this patch fixes.
- rmudgett
On July 2, 2014, 4:34 a.m., one47 wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3700
reading the body to discard in
ast_http_body_discard().
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3691/#review12407
ast_flags may be an appropriate solution.
Done.
You lose language support for using the ast_xxx_flag() macros. And the macros
more or less do what the bitfields are going to do unless you work with more
than one flag at a time.
- rmudgett
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
parties.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
open and processed repeated requests until
they idle timed out.
Performed the following get:
GET /httpstatus HTTP/1.1
Connection: close
Observed that the connection closed as requested when completed.
Thanks,
rmudgett
the ast_tcptls_server_read() and ast_tcptls_server_write()
functions instead.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3653/#review12371
routine. The basic bridge pull routine then directly called
the base bridge pull routine again.
I'll add a comment.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3601
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3677/#review12340
---
Ship it!
Ship It!
- rmudgett
On June 25, 2014, 10:21 p.m
/channels/chan_dahdi.c
https://reviewboard.asterisk.org/r/3681/#comment22547
span case
/trunk/channels/chan_dahdi.c
https://reviewboard.asterisk.org/r/3681/#comment22546
curlies
/trunk/channels/chan_dahdi.c
https://reviewboard.asterisk.org/r/3681/#comment22548
span case
- rmudgett
://reviewboard.asterisk.org/r/3681/#comment22553
[]'s are used to indicate optional items.
's are used to indicate user filled in items.
For xml you need to use lt gt for .
/trunk/channels/chan_dahdi.c
https://reviewboard.asterisk.org/r/3681/#comment22554
same here
- rmudgett
://reviewboard.asterisk.org/r/3684/#comment22570
These descriptions don't match with the test since the test is for hook
inheritance.
- rmudgett
On June 26, 2014, 2:32 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12312
---
Ship it!
Looks OK to me.
- rmudgett
On June 25, 2014, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3672/#review12329
---
Ship it!
Ship It!
- rmudgett
On June 25, 2014, 6:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/#review12294
---
Ship it!
I'll commit the patch.
- rmudgett
On June 24
://reviewboard.asterisk.org/r/3649/#comment22472
2014
- rmudgett
On June 24, 2014, 1:06 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649
with each other, but I
suspect it's fine.
Probably should not mix them anyway.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12297
/main/astobj2_container.c
https://reviewboard.asterisk.org/r/3670/#comment22475
Add comment that was there previously:
/* Unref the node from the container. */
- rmudgett
On June 24, 2014, 1:28 a.m., Corey Farrell wrote
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
https://reviewboard.asterisk.org/r/3633/#comment22351
red blobs
i.e. trailing whitespace
- rmudgett
On June 20, 2014, 6:24 a.m., Pavel Troller wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On June 20, 2014, 2:56 p.m., rmudgett wrote:
/branches/11/UPGRADE.txt, lines 23-30
https://reviewboard.asterisk.org/r/3633/diff/2/?file=59969#file59969line23
Changing UPGRADE is not necessary. This is fixing a regression.
Documenting the new option is only needed
performance.
The AO2_CONTAINER_ALLOC_OPT_DUPS_OBJ_REJECT should generally provide better
performance than the other duplicate options.
- rmudgett
On June 10, 2014, 9:42 a.m., George Joseph wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3548/#review12237
---
Ship it!
Ship It!
- rmudgett
On June 17, 2014, 1:30 p.m
of the function. Outside the
function it now has an implied global scope.
Should add doxygen to it.
branches/12/tests/test_astobj2.c
https://reviewboard.asterisk.org/r/3593/#comment22325
Should add doxygen for what ITERATIONS means.
- rmudgett
On June 19, 2014, 4:26 p.m., George
/channels/chan_dahdi.c
https://reviewboard.asterisk.org/r/3633/#comment22332
Put underbars in the option name for readability.
- rmudgett
On June 19, 2014, 9:20 a.m., Pavel Troller wrote:
---
This is an automatically generated e-mail
501 - 600 of 861 matches
Mail list logo
